Implement class for PageInfoWindow

RESOLVED FIXED in mozilla39

Status

P1
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Version 3
mozilla39
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Similar to the class in Mozmill tests we need a PageInfoWindow class for extensive checks of certificate data, and others.

I will start working on it now.
Chris, I have started with the implementation on PR 84:
https://github.com/mozilla/firefox-ui-tests/pull/84

The general window handling logic is in. Now all the elements will have to be added and category switching. I assume for each category we want a separate class to reduce complexity.

I have to head out soon, so I won't be able to finish it up. It would be great if you could continue here for today. I can do the rest on Wednesday next week.
:whimboo, I'm planning to work on other marionette bugs this afternoon and I'm off Monday and Tuesday (as you are). Let's put our heads together next week and talk about priorities.
Alright. So I will continue with that module on Wednesday together with the security library. Both will unblock our P1 tests for security.
Created attachment 8570421 [details] [review]
github_pull_request.txt
Attachment #8570421 - Flags: review?(cmanchester)
Comment on attachment 8570421 [details] [review]
github_pull_request.txt

Looks good. Had a question about the design in the PR I'd like to resolve.
Attachment #8570421 - Flags: review?(cmanchester) → feedback+
Comment on attachment 8570421 [details] [review]
github_pull_request.txt

I pushed all the updates as requested. Travis for Linux passed, but OS X is still running. Please review and merge if totally necessary. Otherwise I can do it early tomorrow.
Attachment #8570421 - Flags: review?(cmanchester)
Comment on attachment 8570421 [details] [review]
github_pull_request.txt

One optional nit. This is good to go!
Attachment #8570421 - Flags: review?(cmanchester) → review+
Nits have been addressed, and the PR been merged as:

https://github.com/mozilla/firefox-ui-tests/commit/239d94a7510319119286534999754cf51777d318
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Priority: -- → P1
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.