Closed
Bug 1133002
Opened 8 years ago
Closed 8 years ago
"I'll be careful" button shouldn't be centered in about:config
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: ntim, Assigned: abdelrahman, Mentored)
References
Details
(Whiteboard: [good first bug][lang=xul])
Attachments
(1 file)
1.14 KB,
patch
|
jaws
:
review+
jaws
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•8 years ago
|
||
To fix this bug, you need to remove pack="center" from [0], and add a button-container class to that hbox. [0] : https://dxr.mozilla.org/mozilla-central/source/toolkit/components/viewconfig/content/config.xul?from=config.xul&case=true#63
Mentor: ntim007
Whiteboard: [good first bug][lang=xul]
Assignee | ||
Comment 2•8 years ago
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8564641 [details] [diff] [review] rev 1 - align warning button to left Review of attachment 8564641 [details] [diff] [review]: ----------------------------------------------------------------- This looks close, but it would be nice if the left-side of the button lined with up the text above it. See http://screencast.com/t/yMmgfiorS for a screenshot from Windows 8.1.
Attachment #8564641 -
Flags: review?(jaws) → feedback+
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3) > Comment on attachment 8564641 [details] [diff] [review] > rev 1 - align warning button to left > > Review of attachment 8564641 [details] [diff] [review]: > ----------------------------------------------------------------- > > This looks close, but it would be nice if the left-side of the button lined > with up the text above it. See http://screencast.com/t/yMmgfiorS for a > screenshot from Windows 8.1. That's bug 1133246 which affects all pages using info-pages.css
Updated•8 years ago
|
Attachment #8564641 -
Flags: review?(jaws)
Updated•8 years ago
|
Attachment #8564641 -
Flags: review?(jaws) → review+
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/371308353f46
Keywords: checkin-needed
Whiteboard: [good first bug][lang=xul] → [good first bug][lang=xul][fixed-in-fx-team]
Comment 6•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/371308353f46
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=xul][fixed-in-fx-team] → [good first bug][lang=xul]
Target Milestone: --- → Firefox 38
Updated•8 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•