Closed Bug 1133030 Opened 9 years ago Closed 9 years ago

Intermittent browser_webconsole_bug_632817.js | Test timed out

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox36 unaffected, firefox37 unaffected, firefox38 fixed, firefox-esr31 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 38
Tracking Flags:
Tracking Status
firefox36 --- unaffected
firefox37 --- unaffected
firefox38 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: sjakthol)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

webconsole-bug-632817-timeout.patch
1.17 KB, patch
past
: review+
Details | Diff | Splinter Review 
10:55:02 INFO - 5798 INFO TEST-START | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js
10:55:47 INFO - Xlib: extension "RANDR" missing on display ":0".
10:55:49 INFO - TEST-INFO | screentopng: exit 0
10:55:49 INFO - 5799 INFO checking window state
10:55:49 INFO - 5800 INFO TEST-PASS | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js | Page load was logged
10:55:49 INFO - 5801 INFO TEST-PASS | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js | Logged network entry is page load
10:55:49 INFO - 5802 INFO TEST-PASS | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js | Method is correct
10:55:49 INFO - 5803 INFO TEST-PASS | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js | Page load was logged again
10:55:49 INFO - 5804 INFO TEST-PASS | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js | testXhrGet() was logged
10:55:49 INFO - 5805 INFO TEST-PASS | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js | Method is correct
10:55:49 INFO - 5806 INFO Console message: [JavaScript Warning: "Loading mixed (insecure) active content "http://example.com/" on a secure page" {file: "https://example.com/browser/browser/devtools/webconsole/test/test-network-request.html" line: 9}]
10:55:49 INFO - 5807 INFO Console message: [JavaScript Warning: "Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://example.com/. (Reason: CORS header 'Access-Control-Allow-Origin' missing)."]
10:55:49 INFO - 5808 INFO TEST-UNEXPECTED-FAIL | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js | Test timed out - expected PASS
10:55:49 INFO - 5809 INFO MEMORY STAT vsize after test: 1147412480
10:55:49 INFO - 5810 INFO MEMORY STAT residentFast after test: 239316992
10:55:49 INFO - 5811 INFO MEMORY STAT heapAllocated after test: 89810016
10:55:49 INFO - 5812 INFO TEST-OK | browser/devtools/webconsole/test/browser_webconsole_bug_632817.js | took 45295ms
Here's a patch that should fix this timeout. I faced a similar issue when working on bug 932179 in which the event timings were not always sent by the server if a cross-origin request was blocked (see bug 932179 comment 31).

The logs indicate that a request from https://example.com to http://example.com was blocked due to missing CORS headers. This test relies on lastFinishedRequest callback to wait for completion and as can be seen from [1] it's only called after timings have arrived.

This patch changes the cross-origin request URI to one that allows cross-origin requests with "Access-Control-Allow-Origin: *" header.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=377e035d3a0c

[1] https://dxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/webconsole.js#1838-1842
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8564481 - Flags: review?(past)
Comment on attachment 8564481 [details] [diff] [review]
webconsole-bug-632817-timeout.patch

Review of attachment 8564481 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8564481 - Flags: review?(past) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/9d7cc5a9570f

<3
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
(In reply to TBPL Robot from comment #17)

Was from a push prior to comment 16.
https://hg.mozilla.org/mozilla-central/rev/9d7cc5a9570f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: