113305 - build failure on tinderboxes

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Sonja Mirtitsch]

on 11/30 15:30 all tinderboxes broke, except AIX: 
Solaris 8:
make[2]: Entering directory
`/export/nss_tbx_sol8/builds/tinderbox/Solaris8/mozilla/security/nss/lib/freebl'
cc -o SunOS5.8_DBG.OBJ/loader.o -c -g -KPIC -DSVR4 -DSYSV -D__svr4 -D__svr4__
-DSOLARIS -D_REENTRANT -DSOLARIS2_8 -D_SVID_GETTOD -xarch=v8 -xs -DXP_UNIX
-DRIJNDAEL_INCLUDE_TABLES -DDEBUG -UNDEBUG -DDEBUG_svbld -DMP_NO_MP_WORD
-DMP_ASSEMBLY_MULTIPLY -DMP_USING_MONT_MULF -DMP_USE_UINT_DIGIT 
-DMP_API_COMPATIBLE -I/usr/dt/include -I/usr/openwin/include
-I../../../../dist/SunOS5.8_DBG.OBJ/include  -I../../../../dist/public/security
-I../../../../dist/private/security -Impi  loader.c
"loader.c", line 958: undefined struct/union member: p_Cleanup
"loader.c", line 958: function designator is not of function type
cc: acomp failed for loader.c
NEXT ERROR gmake[2]: *** [SunOS5.8_DBG.OBJ/loader.o] Error 2
gmake[2]: Leaving directory
`/export/nss_tbx_sol8/builds/tinderbox/Solaris8/mozilla/security/nss/lib/freebl'

---------

NEXT ERROR gmake[1]: *** [libs] Error 2
gmake[1]: Leaving directory
`/export/nss_tbx_sol8/builds/tinderbox/Solaris8/mozilla/security/nss/lib'

---------

gmake[2]: Entering directory
`/export/nss_tbx_sol8/builds/tinderbox/Solaris8/mozilla/security/nss/lib/freebl'
cc -o SunOS5.8_DBG.OBJ/loader.o -c -g -KPIC -DSVR4 -DSYSV -D__svr4 -D__svr4__
-DSOLARIS -D_REENTRANT -DSOLARIS2_8 -D_SVID_GETTOD -xarch=v8 -xs -DXP_UNIX
-DRIJNDAEL_INCLUDE_TABLES -DDEBUG -UNDEBUG -DDEBUG_svbld -DMP_NO_MP_WORD
-DMP_ASSEMBLY_MULTIPLY -DMP_USING_MONT_MULF -DMP_USE_UINT_DIGIT 
-DMP_API_COMPATIBLE -I/usr/dt/include -I/usr/openwin/include
-I../../../../dist/SunOS5.8_DBG.OBJ/include  -I../../../../dist/public/security
-I../../../../dist/private/security -Impi  loader.c
"loader.c", line 958: undefined struct/union member: p_Cleanup
"loader.c", line 958: function designator is not of function type
cc: acomp failed for loader.c
NEXT ERROR gmake[2]: *** [SunOS5.8_DBG.OBJ/loader.o] Error 2
gmake[2]: Leaving directory
`/export/nss_tbx_sol8/builds/tinderbox/Solaris8/mozilla/security/nss/lib/freebl'

Win NT
gmake[2]: Entering directory
`E:\tbx\nss\builds\tbx\stalker_NT\mozilla\security\nss\cmd\bltest'
cl WINNT4.0_DBG.OBJ\\blapitest.obj  -FeWINNT4.0_DBG.OBJ/bltest.exe -link -DEBUG
-DEBUGTYPE:CV ..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\smime.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\ssl.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\jar.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\zlib.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\nss.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\ssl.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\sectool.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\pkcs12.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\pkcs7.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\certhi.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\cryptohi.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\pk11wrap.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\certdb.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\softokn.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\freebl.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\swfci.lib ..\\..\\..\\!
..\\dist\\WINNT4.0_DBG.OBJ\\lib\\secutil.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\nsspki.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\nssdev.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\nssb.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\dbm.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\libplc4.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\libplds4.lib
..\\..\\..\\..\\dist\\WINNT4.0_DBG.OBJ\\lib\\libnspr4.lib   wsock32.lib winmm.lib 
Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 12.00.8168 for 80x86
Copyright (C) Microsoft Corp 1984-1998. All rights reserved.

Microsoft (R) Incremental Linker Version 6.00.8447
Copyright (C) Microsoft Corp 1992-1998. All rights reserved.

/out:WINNT4.0_DBG.OBJ/bltest.exe 
-DEBUG 
-DEBUGTYPE:CV 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\smime.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\ssl.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\jar.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\zlib.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\nss.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\ssl.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\sectool.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\pkcs12.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\pkcs7.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\certhi.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\cryptohi.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\pk11wrap.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\certdb.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\softokn.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\freebl.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\swfci.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\secutil.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\nsspki.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\nssdev.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\nssb.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\dbm.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\libplc4.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\libplds4.lib 
..\..\..\..\dist\WINNT4.0_DBG.OBJ\lib\libnspr4.lib 
wsock32.lib 
winmm.lib 
WINNT4.0_DBG.OBJ\blapitest.obj 
NEXT ERROR softokn.lib(pkcs11.obj) : error LNK2005: _PK11_DestroySlot already
defined in pk11wrap.lib(pk11slot.obj)
softokn.lib(pkcs11.obj) : warning LNK4006: _PK11_DestroySlot already defined in
pk11wrap.lib(pk11slot.obj); second definition ignored
Creating library WINNT4.0_DBG.OBJ/bltest.lib and object WINNT4.0_DBG.OBJ/bltest.exp
NEXT ERROR WINNT4.0_DBG.OBJ/bltest.exe : fatal error LNK1169: one or more
multiply defined symbols found
gmake[2]: *** [WINNT4.0_DBG.OBJ/bltest.exe] Error 2
gmake[2]: Leaving directory
`E:\tbx\nss\builds\tbx\stalker_NT\mozilla\security\nss\cmd\bltest'


form bonsai:

(+2248/2034) Lines changed.
When Who File Rev +/- Description
11/30/2001 15:32 relyea%netscape.com mozilla/ security/ nss/ lib/ nss/ nssinit.c
1.31 22/24 

1) restore the const to PK11_Configure().
2) partial set of fixes from Nelson's review (checking for NULL) from the
'double escape' functions.
3) Add functions to clean up global memory locks
11/30/2001 15:32 relyea%netscape.com mozilla/ security/ nss/ lib/ nss/ nss.h
1.15 4/3 
11/30/2001 15:29 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
rsawrapr.c 1.4 3/3 

The other half of the double check change.
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
softokn.rc 1.3 4/0 

Fix several memory leaks.
Adjust the default hash sizes down for mozilla client.
Merge the NSS 3.3 key check and signature check stuff.
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
pkcs11u.c 1.15 35/4 
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
pkcs11i.h 1.8 13/0 
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
pkcs11c.c 1.25 7/4 
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
pkcs11.c 1.24 124/33 
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
pcertdb.c 1.4 26/11 
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
lowcert.c 1.3 1/56 
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
keydb.c 1.11 5/23 
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
dbinit.c 1.7 10/16 
11/30/2001 15:24 relyea%netscape.com mozilla/ security/ nss/ lib/ softoken/
config.mk 1.5 5/0 
11/30/2001 15:22 relyea%netscape.com mozilla/ security/ nss/ lib/ pk11wrap/
pk11util.c 1.19 3/1 

fix Bug 93989 Memory leak when adding a module.
11/30/2001 15:21 relyea%netscape.com mozilla/ security/ nss/ lib/ freebl/ rsa.c
1.28 38/1 

Add code to 'shutdown' freebl (clean up the blinding cache in rsa).
merge the NSS 3.3 changes to export Ian's double check code through the loader.
11/30/2001 15:21 relyea%netscape.com mozilla/ security/ nss/ lib/ freebl/
loader.h 1.4 11/2 
11/30/2001 15:21 relyea%netscape.com mozilla/ security/ nss/ lib/ freebl/
loader.c 1.6 27/1 
11/30/2001 15:21 relyea%netscape.com mozilla/ security/ nss/ lib/ freebl/
ldvector.c 1.2 5/2 
11/30/2001 15:21 relyea%netscape.com mozilla/ security/ nss/ lib/ freebl/
blapi_bsf.c 1.7 20/0 
11/30/2001 15:21 relyea%netscape.com mozilla/ security/ nss/ lib/ freebl/
blapi.h 1.10 8/1

Comment 1

[Robert Relyea]

This bug is mine...

Comment 2

[Robert Relyea]

Fixes for the two problems should be checked in now.

1) Typo in loader.c (unfortunately AIX does not use loader.c so I didn't check
it in my builds).

2) Symbol collision between softoken and pk11wrap which only showed up linking
static commands.

I'll close this when tinderbox goes green again.

Comment 3

[Sonja Mirtitsch]

tinderboxes green again