Closed Bug 1133057 Opened 9 years ago Closed 9 years ago

TSan: data race dom/media/systemservices/LoadMonitor.cpp:619 FireCallbacks

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: froydnj, Assigned: pkerr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tsan])

Attachments

(1 file)

[cribbing from decoder's script, hopefully he won't mind]

The attached logfile shows a thread/data race detected by TSan (ThreadSanitizer).

Typically, races reported by TSan are not false positives, but it is possible that the race is benign. Even in this case though, we should try to come up with a fix unless this would cause unacceptable performance issues. Also note that seemingly benign races can possibly be harmful (also depending on the compiler and the architecture) [1].

If the bug cannot be fixed, then this bug should be used to either make a compile-time annotation for blacklisting or add an entry to the runtime blacklist.

Inlining has totally botched the responsible functions in the attachment; I believe the read is here:

http://mxr.mozilla.org/mozilla-central/source/dom/media/systemservices/LoadMonitor.cpp#620

and the write is here:

http://mxr.mozilla.org/mozilla-central/source/dom/media/systemservices/LoadMonitor.cpp#659

so we're touching mLoadNotificationCallback on multiple threads without locking.

[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong
bholley, want to take a look at this one, too? :)
Flags: needinfo?(bobbyholley)
This looks like webrtc stuff. Gian-Carlo, can you find an owner?
Flags: needinfo?(bobbyholley) → needinfo?(gpascutto)
Assignee: nobody → pkerr
Flags: needinfo?(gpascutto)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: