Closed Bug 1133060 Opened 5 years ago Closed 5 years ago

Clean up tabbrowser/crashed.svg

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: ntim, Assigned: ntim)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8564354 - Flags: review?(dao)
Comment on attachment 8564354 [details] [diff] [review]
Patch

>+<svg xmlns="http://www.w3.org/2000/svg"
>+     xmlns:xlink="http://www.w3.org/1999/xlink"
>+     x="0" y="0"

x and y attributes do nothing on outer SVG elements, you'd be best omitting them altogether.

>+     viewBox="22 22 16 16"
>+     enable-background="new 22 22 16 16"

You don't need enable-background either (its obsolete in SVG and support was never implemented in gecko)

>+     xml:space="preserve">

Or xml:space as there's no text in the file.

>+  <linearGradient id="gradient" gradientUnits="userSpaceOnUse" x1="30" y1="23" x2="30" y2="37">
>+    <stop offset="0" style="stop-color: #e63b2e"/>
>+    <stop offset="1" style="stop-color: #c33931"/>
>+  </linearGradient>
>+  <circle fill="url(#gradient)" cx="30" cy="30" r="7"/>
>+  <g>
>+    <path fill="#fff" d="M31.03,33.304c0,0.6-0.479,1.092-1.091,1.092c-0.6,0-1.079-0.492-1.079-1.092 c0-0.588,0.479-1.079,1.079-1.079C30.551,32.225,31.03,32.716,31.03,33.304z M29.171,31.133l-0.24-5.253h2.015l-0.24,5.253H29.171z"/>
>+  </g>
> </svg>
And the <g> round the path does nothing and so you could remove that too.
Attached patch Patch v2 (obsolete) — Splinter Review
Thanks Robert ! Addressed your comments.
Attachment #8564354 - Attachment is obsolete: true
Attachment #8564354 - Flags: review?(dao)
Attachment #8564526 - Flags: review?(dao)
Attached patch Patch v2.1Splinter Review
Changed reviewer as :dao is away.
Attachment #8564526 - Attachment is obsolete: true
Attachment #8564526 - Flags: review?(dao)
Attachment #8564590 - Flags: review?(gijskruitbosch+bugs)
Attachment #8564590 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/93f2c43f45e0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.