Closed Bug 1133075 Opened 5 years ago Closed 5 years ago

add more MOZ_OVERRIDE

Categories

(Core :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: tbsaunde, Unassigned)

Details

Attachments

(1 file)

No description provided.
waldo js/
froydnj ipc/ parser/ xpcom/
jrmuizel gfx/
Attachment #8564358 - Flags: review?(nfroyd)
Attachment #8564358 - Flags: review?(jwalden+bmo)
Attachment #8564358 - Flags: review?(jmuizelaar)
Attachment #8564358 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8564358 [details] [diff] [review]
add more MOZ_OVERRIDE

Review of attachment 8564358 [details] [diff] [review]:
-----------------------------------------------------------------

::: parser/htmlparser/nsIParser.h
@@ +119,5 @@
>       * @update harishd,gagan 07/17/01
>       * @param aChannel out param that will contain the result
>       * @return NS_OK if successful
>       */
> +    NS_IMETHOD GetChannel(nsIChannel** aChannel) MOZ_OVERRIDE = 0;

Having a pure virtual MOZ_OVERRIDE function is unusual, but AFAICT the MOZ_OVERRIDE is correct here.

@@ +162,5 @@
>       * Asynchronously continues parsing.
>       */
>      NS_IMETHOD_(void) ContinueInterruptedParsingAsync() = 0;
>  
> +    NS_IMETHOD_(bool) IsParserEnabled() MOZ_OVERRIDE = 0;

Likewise.

I wonder if it'd be worth getting rid of nsParserBase altogether, and making nsIParser the preferred interface here?  I guess maybe clients know that it's safe to call the methods on nsParserBase, but not on nsIParser?
Attachment #8564358 - Flags: review?(nfroyd) → review+
Comment on attachment 8564358 [details] [diff] [review]
add more MOZ_OVERRIDE

Review of attachment 8564358 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the js bit
Attachment #8564358 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/bf0a30e5256c
https://hg.mozilla.org/mozilla-central/rev/42ab578331a6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.