Show a warning when the binary component cannot be loaded

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Lightning Only
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk
4.0.0.1

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Another big release is coming up and we still have libical. It's again likely that some people will manage to install a mismatching Lightning version. This patch at least tells the user what went wrong, instead of leaving him alone with a broken view.
(Assignee)

Comment 1

2 years ago
Created attachment 8564420 [details] [diff] [review]
Fix - v1
Attachment #8564420 - Flags: review?(mohit.kanwal)
(Assignee)

Updated

2 years ago
Target Milestone: --- → 4.0
Comment on attachment 8564420 [details] [diff] [review]
Fix - v1

Review of attachment 8564420 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: calendar/lightning/content/messenger-overlay-sidebar.js
@@ +506,5 @@
> +    const THUNDERBIRD_GUID = "{3550f703-e582-4d05-9a08-453d09bdfdc6}";
> +    const SEAMONKEY_GUID = "{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}";
> +    const LIGHTNING_GUID = "{e2fda1a4-762b-4020-b5ad-a41df1933103}";
> +
> +    return Task.spawn(function*() {

ah cool! new generator function syntax here, looks cool. But why do we need it?
Attachment #8564420 - Flags: review?(mohit.kanwal) → review+
(Assignee)

Comment 3

2 years ago
Ah you are right, a bit overkill to use a Task here. I've switched to just using the callback function.
(Assignee)

Comment 4

2 years ago
Pushed to comm-central changeset e529163574ff
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.