Closed
Bug 1133139
Opened 8 years ago
Closed 8 years ago
Show a warning when the binary component cannot be loaded
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
4.0.0.1
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
5.83 KB,
patch
|
redDragon
:
review+
|
Details | Diff | Splinter Review |
Another big release is coming up and we still have libical. It's again likely that some people will manage to install a mismatching Lightning version. This patch at least tells the user what went wrong, instead of leaving him alone with a broken view.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8564420 -
Flags: review?(mohit.kanwal)
Assignee | ||
Updated•8 years ago
|
Target Milestone: --- → 4.0
Comment 2•8 years ago
|
||
Comment on attachment 8564420 [details] [diff] [review] Fix - v1 Review of attachment 8564420 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. ::: calendar/lightning/content/messenger-overlay-sidebar.js @@ +506,5 @@ > + const THUNDERBIRD_GUID = "{3550f703-e582-4d05-9a08-453d09bdfdc6}"; > + const SEAMONKEY_GUID = "{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}"; > + const LIGHTNING_GUID = "{e2fda1a4-762b-4020-b5ad-a41df1933103}"; > + > + return Task.spawn(function*() { ah cool! new generator function syntax here, looks cool. But why do we need it?
Attachment #8564420 -
Flags: review?(mohit.kanwal) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Ah you are right, a bit overkill to use a Task here. I've switched to just using the callback function.
Assignee | ||
Comment 4•8 years ago
|
||
Pushed to comm-central changeset e529163574ff
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•