113319 - crash on startup - unable to resolve PREF_GetJSRuntime

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Jim Dunn]

The changes to make mozilla/modules/libpref/src/ prefapi.c -> prefapi.cpp
c++ is causing the build to crash on startup (see palermo's tinderbox)

The problem is how PREF_GetJSRuntime is defined and declared in 
nsPrefService.cpp & prefapi.cpp.

Not sure why PREF_GetJSRuntime is defined in nsPrefService instead 
of prefapi.cpp, since it is only used in prefapi.cpp, but anyway.
In the source file where it is defined, you don't need to declare it
extern.  You need to declare it extern in the source file that 
references it.

Comment 1

[Jim Dunn]

Attachment: diff

Here is the diff that works on HP-UX.

Comment 2

[Jim Dunn]

I just looked at PREF_GetJSRuntime in nsPrefService and now understand
while it is there, so ignore the above comment.

I would like permission (r= & sr=) to check in my fix though...

Comment 3

[Alec Flett]

Comment on attachment 60206 [details] [diff] [review]
diff

sr=alecf
the reason it's that way was that previously PREF_GetJSRuntime had to be
written in C++, and prefapi.cpp was called prefapi.c, and thus couldn't do C++
things

Comment 4

[Brian Nesse (gone)]

Comment on attachment 60206 [details] [diff] [review]
diff

r=bnesse.

Comment 5

[Brian Nesse (gone)]

*** Bug 113006 has been marked as a duplicate of this bug. ***

Comment 6

[sairuh (rarely reading bugmail)]

is this limited to HP-UX?

Comment 7

[Jim Dunn]

not sure, nebiros is complaining about something similar (see Seamonkey-Ports)
and I don't have an aix tinderbox (network issue) trying it

Comment 8

[Jim Dunn]

this is indeed busted on AIX (AIX however flags it as a build
issue - too bad we didn't have the AIX tinderbox running, since
it would have been flagged much sooner)

As soon as the tree opens I will check in my fix

Comment 9

[Jim Dunn]

fix checked in