11332 - Base64 encoding of byte streams with 8-bit values

Status: RESOLVED FIXED

(Grendel Graveyard :: Protocols, defect, P3)

Description

[harning]

There seems to be a problem with the Base64 Encoder, when encoding other that
7-bit streems.

MimeBase64Encoder.java reads

 98       if (buf_bytes == 0)
 99         buf = (buf & 0x00FFFF) | (inb[i] << 16);
100       else if (buf_bytes == 1)
101         buf = (buf & 0xFF00FF) | (inb[i] << 8);
102       else
103         buf = (buf & 0xFFFF00) | (inb[i]);

but should read

 98       if (buf_bytes == 0)
 99         buf = (buf & 0x00FFFF) | (inb[i] << 16);
100       else if (buf_bytes == 1)
101         buf = (buf & 0xFF00FF) | ((in[i] << 8) & 0x00FF00);
102       else
103         buf = (buf & 0xFFFF00) | ((in[i]) & 0x0000FF);

the reason beeing that when shifting a negative value (eg. -122=10000110b) 8
positions left the result becomes 1111111110000110b and not 1000011000000000b
the original code assumes.

Comment 1

[harning]

Correction:
the reason beeing that when shifting a negative value (eg. -122=10000110b) 8
positions left the result becomes 111111111000011000000000b and not
1000011000000000b the original code assumes.

Comment 2

[edwin]

I just fixed this. Thanks!

Comment 3

[edwin]

Followup from submitter:

Fine ... I forgot one thing though:
46     (byte)'w', (byte)'x', (byte)'y', (byte)'z', (byte)'', (byte)'1',
(byte)'2', (byte)'3',

(byte)'z', (byte)'', (byte)'1'
should read
(byte)'z', (byte)'0', (byte)'1'

Comment 4

[edwin]

Just entering it in bugzilla until I can fix it.

Comment 5

[Terry Weissman]

Cleared the resolution.  (Bugzilla no longer supports the idea that an open bug
can have any kind of resolution set.)

Comment 6

[Gervase Markham [:gerv]]

This bug has not been touched for more than nine months. In most cases, that 
means it has "slipped through the net". Please could the owner take a moment to 
add a comment to the bug with current status, and/or close it.

Thank you :-)

Gerv

Comment 7

[edwin]

Reassigning to [e-mail] as I'm not working on Grendel anymore.

Comment 8

[R.J. Keller]

Moving to default owners

Comment 9

[R.J. Keller]

Just confirmed that issue described in comment #3 and description no longer
exist. Looks like edwin checked in the fix and forgot to resolve the bug.

--> FIXED