1133260 - browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js is going to permafail when Gecko 38 merges to Aurora

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Test permafail when Gecko 38 merges to Aurora.

The merge is just over a week away. This needs fixing ASAP.

https://treeherder.mozilla.org/logviewer.html#?job_id=4938317&repo=try

20:18:30 INFO - 659 INFO Waiting for TabOpen
20:18:30 INFO - 660 INFO Console message: [JavaScript Error: "TypeError: document.getElementById(...) is null" {file: "chrome://browser/content/aboutSessionRestore.js" line: 37}]
20:18:30 INFO - 661 INFO Saw TabOpen
20:18:30 INFO - 662 INFO Wait tab event: load
20:18:30 INFO - 663 INFO Console message: [JavaScript Warning: "ReferenceError: reference to undefined property params.charset" {file: "chrome://browser/content/tabbrowser.xml" line: 1372}]
20:18:30 INFO - 664 INFO Console message: [JavaScript Warning: "Unknown property 'text-emphasis'. Declaration dropped." {file: "resource://gre-resources/html.css" line: 781 column: 17 source: " text-emphasis: none;"}]
20:18:30 INFO - 665 INFO Console message: [JavaScript Warning: "Error in parsing value for 'unicode-bidi'. Declaration dropped." {file: "resource://gre-resources/html.css" line: 795 column: 18 source: " unicode-bidi: isolate;"}]
20:18:30 INFO - 666 INFO Console message: [JavaScript Error: "invalid 'in' operand dict" {file: "resource://gre/modules/RemoteAddonsChild.jsm" line: 27}]
20:18:30 INFO - 667 INFO Console message: [JavaScript Error: "invalid 'in' operand dict" {file: "resource://gre/modules/RemoteAddonsChild.jsm" line: 27}]
20:18:30 INFO - 668 INFO Console message: [JavaScript Error: "invalid 'in' operand dict" {file: "resource://gre/modules/RemoteAddonsChild.jsm" line: 27}]
20:18:30 INFO - 669 INFO Console message: [JavaScript Error: "TypeError: invalid 'in' operand dict" {file: "resource://gre/modules/RemoteAddonsChild.jsm" line: 27}]
20:18:30 INFO - 670 INFO Console message: [JavaScript Warning: "Unknown property 'text-emphasis'. Declaration dropped." {file: "resource://gre-resources/html.css" line: 781 column: 17 source: " text-emphasis: none;"}]
20:18:30 INFO - 671 INFO Console message: [JavaScript Warning: "Error in parsing value for 'unicode-bidi'. Declaration dropped." {file: "resource://gre-resources/html.css" line: 795 column: 18 source: " unicode-bidi: isolate;"}]
20:18:30 INFO - 672 INFO Console message: [JavaScript Error: "invalid 'in' operand dict" {file: "resource://gre/modules/RemoteAddonsChild.jsm" line: 27}]
20:18:30 INFO - 673 INFO Console message: [JavaScript Error: "invalid 'in' operand dict" {file: "resource://gre/modules/RemoteAddonsChild.jsm" line: 27}]
20:18:30 INFO - 674 INFO Console message: [JavaScript Error: "invalid 'in' operand dict" {file: "resource://gre/modules/RemoteAddonsChild.jsm" line: 27}]
20:18:30 INFO - 675 INFO Console message: [JavaScript Error: "TypeError: invalid 'in' operand dict" {file: "resource://gre/modules/RemoteAddonsChild.jsm" line: 27}]
20:18:30 INFO - 676 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/general/head.js:583 - Error: Timed out while waiting for a 'load'' event
20:18:30 INFO - Stack trace:
20:18:30 INFO - promiseTabLoadEvent/timeout<@chrome://mochitests/content/browser/browser/base/content/test/general/head.js:583:21
20:18:30 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:670:9
20:18:30 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:595:7
20:18:30 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
20:18:30 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:670:9
20:18:30 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:595:7
20:18:30 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Disable browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js for non-e10s test runs. r=?

I don't think this test adds much value when it runs in non-e10s mode.
On top of that, because it relies on browser load events going over the
multiprocess add-on shims, this test will permafail when it goes onto
a channel with the shims disabled (like Aurora at the time of this writing).

So I'm disabling it for non-e10s test runs.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks!

remote:   https://hg.mozilla.org/integration/fx-team/rev/679ce5620669

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/679ce5620669