1133338 - Use verticalhome for flatfish

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Kevin Grandon :kgrandon]

Lots of extra code around to support the old home scree. We should port flatfish to use the vertical home screen and fix any bugs that come out of that.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1133338_flatfish_homescreen > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8564747 [details] [review]
[gaia] KevinGrandon:bug_1133338_flatfish_homescreen > mozilla-b2g:master

Sherman, Ricky - this extra code in the codebase is beginning to be a distraction. I'd like us to use the verticalhome app for flatfish, and fix it up if needed in 3.0. This will allow us to move the classic home screen out of the gaia codebase. Please take a look and let me know what you think.

Thanks!

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8564747 [details] [review]
[gaia] KevinGrandon:bug_1133338_flatfish_homescreen > mozilla-b2g:master

It's fine for me. If you want to remove homescreen from apps, you should also remove it in tablet/engineering.list.

Comment 4

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8564747 [details] [review]
[gaia] KevinGrandon:bug_1133338_flatfish_homescreen > mozilla-b2g:master

Agreed with Ricky, and then we can remove `homescreen.appName` in tablet/settings.json[1] yay!

[1]: https://github.com/mozilla-b2g/gaia/blob/master/build/config/tablet/settings.json#L5

Comment 5

[Sherman Chen [:chens] (inactive)]

I found after flashing this build into tablet we will get a empty homescreen, and back to normal after reboot. This might related to default-homescreen.json pointing to some apps doesn't exist on tablet and cause this problem.

Comment 6

[Kevin Grandon :kgrandon]

(In reply to Sherman Chen [:chens] from comment #5)
> I found after flashing this build into tablet we will get a empty
> homescreen, and back to normal after reboot. This might related to
> default-homescreen.json pointing to some apps doesn't exist on tablet and
> cause this problem.

Thanks for reporting that Sherman. This makes sense. I guess we'll want to write a patch which populates default-homescreen.json based on device type. I'll wait on landing this until that issue is resolved.

Not sure if I can get to this soon, but if you have some cycles and want to work on that, feel free to file a bug and pick it up.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] shamenchens:Bug1133338-FlatfishVerticalHome > mozilla-b2g:master

Comment 8

[Sherman Chen [:chens] (inactive)]

Attachment: Flatfish-Verticalhome.png

Comment 9

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8573049 [details]
Flatfish-Verticalhome.png

Vertical homescreen on flatfish will look like this after apply attachment 8573044 [details] [review], but collections icon looks fuzzy on it.

Comment 10

[Kevin Grandon :kgrandon]

(In reply to Sherman Chen [:chens] from comment #8)
> Created attachment 8573049 [details]
> Flatfish-Verticalhome.png

This is pretty ugly. I'd like to try going to 6 columns[1], but we'd likely need to make some updates to the home screen rendering code. I can probably help with this.

Sherman - how would you like to proceed here? Is it ok to break flatfish like this on master for a while?

[1] https://github.com/mozilla-b2g/gaia/pull/28649/files#diff-b1cd729dc5cbffa4da8fbb0b89d54973R22

Comment 11

[Sherman Chen [:chens] (inactive)]

I think it's ok to do it, but if fuzzy collection icon will be a concern, maybe we can remove collections from homescreen.json first and put them back later.

Comment 12

[Kevin Grandon :kgrandon]

(In reply to Sherman Chen [:chens] from comment #11)
> I think it's ok to do it, but if fuzzy collection icon will be a concern,
> maybe we can remove collections from homescreen.json first and put them back
> later.

I think that's probably fine.

Comment 13

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8573044 [details] [review]
[gaia] shamenchens:Bug1133338-FlatfishVerticalHome > mozilla-b2g:master

Kevin and Ricky, this patch follows Kevin's patch and create different homescreen.json based on device type, but currently removed collections from it before we can have better home screen rendering code, after that we can add it back. Could you review this patch? thanks!

Comment 14

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8573044 [details] [review]
[gaia] shamenchens:Bug1133338-FlatfishVerticalHome > mozilla-b2g:master

r+, fix the nit before landing thanks!

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8573044 [details] [review]
[gaia] shamenchens:Bug1133338-FlatfishVerticalHome > mozilla-b2g:master

Thank you!

Comment 16

[Sherman Chen [:chens] (inactive)]

Nits fixed, thanks :)

Comment 17

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/490dad4c806e0c869cb3cba0e63a5c54ea176c47

Comment 18

[Kevin Grandon :kgrandon]

Oops, looks like autolander is trying to land both pull requests here at the same time. Seems it's running into a few build test failures, but I think it should work. (Though it looks like mine wasn't needed)

Comment 19

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/70fb49fb147d237ce3de4654daef2976e23fbfba

Comment 20

[mac]

For me as an end user it us uncomfortable that Homescreen on flatfish is horizaontal or vertical only. There are apps that are horizontal, some are vertical. Then when use of them and press Home button (software or by gesture) it is extremely annoying that app was horizontal (like Music App) and after press Home button vertical Homescreen appears (when user holds tablet still in horizontal). Android is able to do relocation of icons on tablets what helps a lot. Here also should be such feature.