Migrate the classic homescreen into its own project

RESOLVED FIXED in 2.2 S11 (1may)

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
2.2 S11 (1may)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
We should migrate the classic home screen into a new github repo and upload it to the marketplace.
Created attachment 8564755 [details] [review]
[gaia] KevinGrandon:bug_1133347_remove_classic_homescreen > mozilla-b2g:master
(Assignee)

Updated

4 years ago
Blocks: 1134952
(Assignee)

Updated

4 years ago
Blocks: 1135334
(Assignee)

Updated

4 years ago
Blocks: 1139374
(In reply to Kevin Grandon :kgrandon from comment #0)
> We should migrate the classic home screen into a new github repo and upload
> it to the marketplace.

Is it using only privileged apis?
(Assignee)

Comment 3

4 years ago
(In reply to Fabrice Desré [:fabrice] from comment #2)
> Is it using only privileged apis?

Not yet, I guess that's something we would need to fix before uploading. Also would need to figure out the gaia shared/build pieces as well.
Maybe just moving it to a $gaia/attic would be good enough?
(Assignee)

Comment 5

4 years ago
I do think it would be very compelling to upload this to the Marketplace. It would be a good use of the replaceable home screen feature. Archiving it in attic/ would probably be fine initially though.
(Assignee)

Comment 6

4 years ago
Cristian - what are your thoughts on uploading the classic home screen into its own repo under the mozilla-b2g org? I'd like to see about spinning this off and potentially using it for a replaceable home screen demo. Is this work that you'd be interested in doing and want to help with?
Flags: needinfo?(crdlc)
(In reply to Kevin Grandon :kgrandon from comment #6)
> Cristian - what are your thoughts on uploading the classic home screen into
> its own repo under the mozilla-b2g org? I'd like to see about spinning this
> off and potentially using it for a replaceable home screen demo. Is this
> work that you'd be interested in doing and want to help with?

Hi Kevin, I don't have problem with this idea. Quite the opposite, I would be nice. But I cannot take this because I have other tasks in my company right now and I cannot work on this. Sorry for that
Flags: needinfo?(crdlc)
(Assignee)

Comment 8

4 years ago
I've done an initial import of the classic home screen into this repository: https://github.com/mozilla-b2g/classic-homescreen

I'm going to spend some time getting it to work as a privileged home screen next.
(Assignee)

Comment 9

4 years ago
Comment on attachment 8564755 [details] [review]
[gaia] KevinGrandon:bug_1133347_remove_classic_homescreen > mozilla-b2g:master

Ricky, Tim - please be careful loading this, the diff is quite large and causes my browser some problems.

Ricky - if you could please review the changes to the build system, which should currently be contained within this commit: https://github.com/KevinGrandon/gaia/commit/a696ba8b0d71a5b521b13ebd580491fad1ba0ea2

Tim - just looking for a sign off if this looks good to you. The home screen has been migrated to this external repository: https://github.com/mozilla-b2g/classic-homescreen There's still a bit of work to do here including figuring out what's needed for a build system (might be good for a modular build system) as well as localization efforts if we desire.
Attachment #8564755 - Flags: review?(timdream)
Attachment #8564755 - Flags: review?(ricky060709)
Comment on attachment 8564755 [details] [review]
[gaia] KevinGrandon:bug_1133347_remove_classic_homescreen > mozilla-b2g:master

I don't need to sign off the changes -- you should ask one of the Gaia:Homescreen owners. I however would advice we hold off this fix until we could either get a firm confirmation from the product side on not shipping the app EVER, or we could make sure classic-homesceen repo can be integrated w/o a lot of troubles. 

Also in the classic-homesceen repo, I would use git filter-branch to preserve the history of home screen app, but that's up to you.
Attachment #8564755 - Flags: review?(timdream)
(Assignee)

Comment 11

4 years ago
(In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to queue) from comment #10)
> Comment on attachment 8564755 [details] [review]
> [gaia] KevinGrandon:bug_1133347_remove_classic_homescreen >
> mozilla-b2g:master
> 
> I don't need to sign off the changes -- you should ask one of the
> Gaia:Homescreen owners. I however would advice we hold off this fix until we
> could either get a firm confirmation from the product side on not shipping
> the app EVER, or we could make sure classic-homesceen repo can be integrated
> w/o a lot of troubles. 

Sounds good. The plan is to move this into an external repo, and if we need to re-integrate it we have a few options. We can re-land, but my recommendation would be to do what we do with loop - using the outoftree_apps folder.

> Also in the classic-homesceen repo, I would use git filter-branch to
> preserve the history of home screen app, but that's up to you.

Sounds good, I will look at doing this.
(Assignee)

Comment 12

4 years ago
Comment on attachment 8564755 [details] [review]
[gaia] KevinGrandon:bug_1133347_remove_classic_homescreen > mozilla-b2g:master

Cristian - could you sign off on this? The work to migrate to an external repo is in progress, and the app should be working there soon. The goal is to get this uploaded to the marketplace. Thanks!
Attachment #8564755 - Flags: review?(crdlc)
Comment on attachment 8564755 [details] [review]
[gaia] KevinGrandon:bug_1133347_remove_classic_homescreen > mozilla-b2g:master

I don't see any potential problem in this patch, r+ for build part.
Attachment #8564755 - Flags: review?(ricky060709) → review+
Comment on attachment 8564755 [details] [review]
[gaia] KevinGrandon:bug_1133347_remove_classic_homescreen > mozilla-b2g:master

thanks a lot
Attachment #8564755 - Flags: review?(crdlc) → review+
(Assignee)

Comment 15

4 years ago
Awesome, I was able to preserve history and did a new import: https://github.com/mozilla-b2g/classic-homescreen/commits/1961bb0f9e9f08471c9c6222cf816044b3385279

Adding checkin-needed as we are good to go here and can start working on the external repository. There's some gecko bugs to fix before it will fully work as a privileged app.
Keywords: checkin-needed

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Created attachment 8593105 [details] [review]
[gaia] KevinGrandon:bug_1133347_remove_old_legacy_definitions > mozilla-b2g:master
(Assignee)

Comment 18

3 years ago
Landed a follow-up to remove old test definitions from tbpl-manifest: https://github.com/mozilla-b2g/gaia/commit/eff65532a7b5a4edca995cf05b8f3ec5b56aaafa
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.