1133360 - [Private Browser] Update identification overlay

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

According to spec, we should have a darker edge gesture identification overlay.

https://mozilla.app.box.com/s/fanxlaw7ilhm0walsod6hy4ps47v9eh3

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1133360-private-splash > mozilla-b2g:master

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8564777 [details] [review]
[gaia] mikehenrty:bug-1133360-private-splash > mozilla-b2g:master

Only requesting feedback for now since we are still waiting on the final assets. But let's start the review process in the meantime.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8564777 [details] [review]
[gaia] mikehenrty:bug-1133360-private-splash > mozilla-b2g:master

Still need the assets here, but this is looking good. I'm a fan of the approach. Thanks!

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8564777 [details] [review]
[gaia] mikehenrty:bug-1133360-private-splash > mozilla-b2g:master

Ok, assets uploaded, css adjusted.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] private overlay

Eric, this bug handles the overlay that appears over the private browser windows during edge gestures. The spec didn't mention icon size, so I kept them the same size as other icons (like browser) in this scenario. It looks different from the spec, but it seems weird to me to have an icon size that's bigger than all the other icons during edge gestures. What do you think?

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8564777 [details] [review]
[gaia] mikehenrty:bug-1133360-private-splash > mozilla-b2g:master

The patch is looking good, but I have a few comments on github I'd like to have answered before leaving the R+. Please address and re-flag me for review. Thanks!

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8564777 [details] [review]
[gaia] mikehenrty:bug-1133360-private-splash > mozilla-b2g:master

Ah nice catch about the test. I also update the code based on your suggestion.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8564777 [details] [review]
[gaia] mikehenrty:bug-1133360-private-splash > mozilla-b2g:master

I left a nit on github, but this looks good. Thank you!

Comment 9

[Eric Pang [:epang] UX]

Comment on attachment 8565013 [details]
[screenshot] private overlay

That was fast :). Makes sense to me. R+
Thanks!

Comment 10

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#lWIPduSySQqLDoP3jyGPxA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 11

[Kevin Grandon :kgrandon]

Hmm, not sure what's going on here. Will check with the TC folks. Let's try once more.

Comment 12

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#EAqlAVVUT_ej2Zv4kj4GQw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 13

[Kevin Grandon :kgrandon]

Let's try once more...

Comment 14

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#It3KcoG6RfyXnqvZXOMYfg

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 15

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/137948ea0e036305b007b40d26aa57de4b1737e8

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8564777 [details] [review]
[gaia] mikehenrty:bug-1133360-private-splash > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): new feature.

[User impact] if declined:
Missing feature for private browsing spec.

[Testing completed]:
Manually tested, and added unit test.

[Risk to taking this patch] (and alternatives if risky):
Simple change to the way we fetch icons for the edge gesture overlay. Small risk.

[String changes made]: none.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/cf5cdd7122f7aa36d62c27fbd53e6246be9eed42