Closed Bug 1133370 Opened 5 years ago Closed 5 years ago

MOZ_ASSERT failure when GMP calls Error callback

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: eflores, Assigned: eflores)

References

Details

Attachments

(2 files)

Found this crash trying to reproduce bug 1107241.

MediaDataDecoderCallbackProxy::Error() propagates the error to the rest of the media stack and then redundantly calls Shutdown(). This leads to fatal assertion failures when the error handling code tries to flush and shutdown the decoder later on.

Patch is green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6ba51e9f72d
Attachment #8564788 - Flags: review?(kinetik)
Attachment #8564788 - Flags: review?(kinetik) → review+
https://hg.mozilla.org/mozilla-central/rev/0741e9b56498
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Attached patch Beta patchSplinter Review
Patch for beta branch as part of EME platform uplift.
Comment on attachment 8572370 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.
Attachment #8572370 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.