1133390 - onfocuschanged(false) will be notified twice.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Suppose there are two apps(browser-elements) called A and B.
Consider the following calling sequenece:

(1) A.setNFCFocus(true)  ---->                       Gecko
(2) A                    <---- onFocusChanged(true)  Gecko
(3) B.setNFCFocus(true)  ---->                       Gecko
(4) A                    <---- onFocusChanged(false) Gecko
(5) B                    <---- onFocusChanged(true)  Gecko
(6) A.setNFCFocus(false) ---->                       Gecko
(7) A                    <---- onFocusChanged(false) Gecko


In Step 6, setNFCFocus(false) is called on a Browser-Element
which has lost focus already, so step 7 should not be executed.
The onFocusChanged(false) for A is already done in Step 4.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f379cddbf40e

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8564843 [details] [diff] [review]
Patch.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
Bug 1105666

User impact if declined: 
Right now we don't find any problem if declined. However we'd like to request to uplift this to prevent some potential problem.

Testing completed: 
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
No

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f379cddbf40e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3daa393da2f9