113340 - Compose, Formatting toolbar: Alignment drop-down menu items don't have icons/images

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Olga]

Build 2001-12-30

Overview: Alignment drop-down menu items don't have icons/images for Classic
theme in the New Message Compose window, Formatting toolbar - all platforms.

Steps to reproduce: Preferences: Classic theme. Then Ctrl+M and click on the
message body to activate all Formatting options. Check Alignment icon: its
drop-down menu items don't have images in front.

Actual Results: No images next to drop-down menu items.

Expected Results: Images/icons are displayed in front of the Left, Center,
Right, Justify menu items on the Formatting toolbar.

Additional Information: Related bug 63624 for Insert.

Comment 1

[sairuh (rarely reading bugmail)]

bug 113027, perhaps?

Comment 2

[Chris Brien]

This is not the same as bug 113027. The CSS style is set to the wrong size in
that bug. Here, the image source isn't being set because the css rules aren't
applying to the align menu.

"chrome://editor/skin/editorFormatToolbar.css" looks completely wrong for the
classic theme. It uses entities like "#text-align-left" and
"#align-left-button", whereas they are defined in
"chrome://editor/content/editorOverlay.xul" (and used in the modern theme) as
being like "#AlignLeftItem".

Comment 3

[Olga]

Yes, I wrote a note in that bug, but forgot to mention here.

Comment 4

[Chris Brien]

Attachment: Patch to editorFormatToolbar.css

This patch adds the entity names (like AlignLeftItem) to the already-existing
css rules for the alignment icons.

Comment 5

[Neil Pryde]

When did you first see this problem, build ID ?

Comment 6

[Olga]

Build 2001-12-03.

Comment 7

[Olga]

Updating multiple bugs. This is a valid UI issue. Would be nice to have it fixed
if time allows.

Comment 8

[scottputterman]

reassigning to varada and cc'ing cmanske.

Comment 9

[Aleksey Nogin]

Very sorry for the spam, typed 113340 instead of 113430 several times.

Comment 10

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 11

[(not reading, please use [e-mail] instead)]

it appears fixed on windows on my recent trunk build.

looking in lxr, it appears that hewitt fixed it back on Dec 19 2001.

see his checking comment about XUL/theme simplification changes
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/themes/classic/editor/editorFormatToolbar.css

one thing that we could do is further clean up the css so that the rules aren't
duplicated.

we've got:

340            #AlignLeftItem {
341              -moz-image-region: rect(146px 16px 162px 0px);
342            }

and

204            #align-left-button {
205              -moz-image-region: rect(146px 16px 162px 0px);
206            }

if we unify those rules we'll prevent someone from changing one and forgetting
about the other.

we could either do what chris brien's patch does, or fix the xul (and possibly
js) to use the same id, instead of two different ids.

re-assign to hewitt, so he gets credit for the fix.

I'll log a spin off bug about the .css, but it is a low, low priority bug.

Comment 12

[(not reading, please use [e-mail] instead)]

fixed by hewitt.

spin off bug is bug #187606

Comment 13

[laurel]

Looks OK in classic on jan6 commercial trunk: win98, linux rh8.0, mac OS 10.2