1133445 - The security information doorhanger is misplaced

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-02-16-09-07-26.png

Tested with:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 38.0a1 (2015-02-14)

Steps to reproduce:
1. Go to gmail.com 
2. Tap on the security lock.

Expected results:
- The security information doorhanger is correctly displayed.

Actual results:
- The security information doorhanger is misplaced (Please see attached screenshot)

Note:
- this is a recent regression:
good build: 12-02
bad build: 13-02
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3094601af679&tochange=2f5c5ec1a24b

Bug 1124711 - Site identity popup overlaps the URL Bar on phone ?

Comment 1

[Teodora Vermesan (:TeoVermesan)]

Yes. I can confirm is Bug 1124711.
fx-team regression:
good build: 1423685617  
bad build: 1423686159  

pushlog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=ba0c52229c09&tochange=9e88eb0cb0d2

Comment 2

[Allison Naaktgeboren :ally]

Given that it's anchored to the left of the url bar, that's bizarre.

Aaron, can you give me some idea of what devices are affected?

Comment 3

[Teodora Vermesan (:TeoVermesan)]

I was able to reproduce the issue on: Samsung Galaxy Nexus (Android 4.2.1), Samsung S5 (Android 4.4.2), Nexus 4 (Android 5.0.1), Alcatel One Touch (Android 4.1.2), Nexus 5 (Android 5.0.1), Nexus 7 (Android 5.0.1), Samsung Galaxy Tab 2 (Android 4.2.2) and on Sony Xperia Z2 (Android 4.4.4.), Acer Iconia (Android 3.2.1) and Samsung Galaxy Tab (Android 4.0.4) the issue is a little bit different: http://i.imgur.com/cKJiu6X.png

Comment 4

[Allison Naaktgeboren :ally]

So I can see this on my nexus 5 only for accounts.google.com.

Teodora, are there any other sites that are affected?

Comment 5

[Teodora Vermesan (:TeoVermesan)]

I can reproduce on all sites that display security lock (either gray or green): facebook.com, addons.mozilla.org, bugzilla.mozilla.org. Also news.google.com or youtube.com have a favicon and by tapping it, the doorhanger is misplaced.

Comment 6

[Allison Naaktgeboren :ally]

margaret also reports seeing this outside of accounts.google.com, so that makes me suspect theres something wrong with my local build on the nexus 5

Comment 7

[:Margaret Leibovic]

I see this arrow misplaced for the site identity popup on all sites, including non-SSL ones (just clicking the favicon), on both a Neuxs 4 and Moto X.

Comment 8

[:Margaret Leibovic]

Looking at the patch that landed in bug 1124711, I now realize I think we just did the wrong thing, and I'm surprised that that patch worked. I haven't looked into the arrow position logic in a while, but at one point we did have some logic to hard-code the left offset of the arrow for phones, but we dynamically positioned it for tablets. So maybe that hard-coded code path made this look right, but the dynamically positioned arrow would be wrong.

In that patch, we changed the anchor to be the title instead of the favicon, so it makes sense that the arrow is now pointing to the favicon.

I think we should probably just back that patch out and try to find a better solution.

Comment 9

[Allison Naaktgeboren :ally]

Have re-opened original bug and requested back out.

Comment 10

[:Margaret Leibovic]

Resoling this as FIXED by the backout.

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Tapping on the security lock, the arrow from the security information doorhanger is correctly displayed, under the security lock.
Verified as fixed:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 38.0a1 (2015-02-22)