1133452 - [Gaia-ui-test][Keyboard] not working in Nexus-5

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Walter Chen[:ypwalter][:wachen]]

This doesn't work in Nexus5. I think this should be moved out of def switch_to_keyboard(self) in apps/keyboard/app.py, and it should be a different function since switch_to_keyboard should really only contains the action of switching to the keyboard.

input_window = self.marionette.find_element(*self._input_window_locator)
Wait(self.marionette).until(lambda m: 'active' in input_window.get_attribute('class') and input_window.location['y'] == 0, message='Keyboard inputWindow not interpreted as displayed. Debug is_displayed(): %s, class: %s.' % (input_window.is_displayed(), input_window.get_attribute('class')))

Comment 1

[Walter Chen[:ypwalter][:wachen]]

This is block MTBF from running on Nexus5

Comment 2

[Paul Yang [:pyang] (away)]

John - Do you have a chance to see this issue? thanks

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Walter, could you give me more information on "this doesn't work"? Is it that the condition passes even though the keyboard has not showed up, or is it that the condition fails even though the keyboard has showed up, or something else?

Also, do you mean that you always get this, on any kind of tests that use keyboard?

It quite beats me why it doesn't work on a specific hardware; I'll need to hook WebIDE to see what's wrong there. Can I borrow a Nexus 5 from you to check? Thanks.

Comment 4

[Walter Chen[:ypwalter][:wachen]]

Hi, I only did. I showed you the code that is not working. Other than that, I have no further information. You can have one device from me.

Yes, almost any kind of tests with keyboard.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] mnjul:bug_1133452_gaia_python_ui_test_kb_fail_shb > mozilla-b2g:master

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

(In reply to Autolander from comment #5)
> Created attachment 8565293 [details] [review]
> [gaia] mnjul:bug_1133452_gaia_python_ui_test_kb_fail_shb > mozilla-b2g:master

Walter, could you try if this patch resolves the issue for you? Thanks.

Comment 7

[Walter Chen[:ypwalter][:wachen]]

Comment on attachment 8565293 [details] [review]
[gaia] mnjul:bug_1133452_gaia_python_ui_test_kb_fail_shb > mozilla-b2g:master

I think this patch is cool as I verified this morning. Thanks.

Comment 8

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8565293 [details] [review]
[gaia] mnjul:bug_1133452_gaia_python_ui_test_kb_fail_shb > mozilla-b2g:master

Hi Dave,

I'd like to ask you to review this patch (we used to have it reviewed by :zacc)  for modification of Python Gaia-UI test scripts.

Keyboard-related mechanisms failed on Nexus 5 because Software Buttons were present and the target "y"-position of Keyboard, according to which we decide the displayed-ness and hidden-ness of the Keyboard, was not what we'd expected.

The test script has been amended to take the software buttons container's height into account by modifying the System app python module to expose such information.

Thanks!

Comment 9

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8565293 [details] [review]
[gaia] mnjul:bug_1133452_gaia_python_ui_test_kb_fail_shb > mozilla-b2g:master

Remove r? as Walter told me some tests were still broken.

Comment 10

[Walter Chen[:ypwalter][:wachen]]

I reconfirmed that it is okay to go. I think I got some failures due to some settings in the CI server. The patch is okay to go.  Thanks so much.

Comment 11

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8565293 [details] [review]
[gaia] mnjul:bug_1133452_gaia_python_ui_test_kb_fail_shb > mozilla-b2g:master

(In reply to Walter Chen[:ypwalter][:wachen] from comment #10)
> I reconfirmed that it is okay to go. I think I got some failures due to some
> settings in the CI server. The patch is okay to go.  Thanks so much.

Awesome!

Dave, could you review this patch? See comment 8 for details.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8565293 [details] [review]
[gaia] mnjul:bug_1133452_gaia_python_ui_test_kb_fail_shb > mozilla-b2g:master

Looks good. I'd personally prefer the property name software_buttons_height over sw_buttons_height, and a docstring would be great, but r+ as is.

Comment 13

[John Lu [:mnjul][Please NI or I'll miss]]

Since the patch is 1-week old, I rebased the patch and took the opportunity to address Dave's comments. I'm waiting for the Gaia-Try run; Gaia tree is currently closed and I'll land once Gaia re-opens.

Comment 14

[Walter Chen[:ypwalter][:wachen]]

umm... I think this will block nexus5 L build regular MTBF testing. nominating this so that bhavana might have a chance to push it through faster.

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f90aea50309bbca3569ac39184210fb471e6524c

Comment 16

[Walter Chen[:ypwalter][:wachen]]

hold on. I think this is not running smooth on nexus5 L v2.2 pvt build.

Comment 17

[Alison Shiue]

I think this patch works after try more test. Please uplift to v2.2, thanks.

Comment 18

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8565293 [details] [review]
[gaia] mnjul:bug_1133452_gaia_python_ui_test_kb_fail_shb > mozilla-b2g:master

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #): None; it's just that some Python Gaia-UI test scripts had not been written with the idea in mind that they could some day run against a real phone with Software Buttons always enabled.

[User impact] if declined: User is not impacted, but QA work on Nexus 5 such as MTBF/Smoketest/... is severely impacted, as any test involving input from keyboard would break.

[Testing completed]: Yes (also, on Gaia-Try, Gip still greens), and manually verified by QA folks for their purposes.

[Risk to taking this patch] (and alternatives if risky): Minimal. Again this patch only modifies test scripts and no end user-facing mechanisms were changed.

[String changes made]: None

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/545d4b789f3c9619fe78ccc52496e30965ad92cb

Comment 20

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified as fixed. I was able to run gaia functional test 'test_keyboard.py' on Nexus 5 passing it without issue.

Verified on:
Build ID               20151124191011
Gaia Revision          7726bfd621d709fa2d179704a44aebc1c309c296
Gaia Date              2015-11-24 15:12:43
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/124375497b14260515e8d2af9c8507a9995b7a47
Gecko Version          44.0a2
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.worker.20151124.181638
Firmware Date          Tue Nov 24 18:16:53 UTC 2015
Bootloader             HHZ12d

Build ID               20151124120300
Gaia Revision          e63c07af8cc636b9ffac2c20f9b8ad7e7fe2b977
Gaia Date              2015-11-24 03:47:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/45273bbed8efaface6f5ec56d984cb9faf4fbb6a
Gecko Version          45.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.worker.20151124.111855
Firmware Date          Tue Nov 24 11:19:13 UTC 2015
Bootloader             HHZ12d