Closed Bug 1133454 Opened 9 years ago Closed 9 years ago

[System] having a name attribute on search app

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S7 (6mar)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: wachen, Assigned: gduan)

References

Details

Attachments

(1 file)

[gaia] cctuan:1133454 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
alive
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
I found that there is no "name" attribute on system app. Is it possible to give it an app name or at least empty string?
Blocks: MTBF-B2G
George - Could you comment for this issue?  Thanks.
Flags: needinfo?(gduan)
Assignee: nobody → gduan
Flags: needinfo?(gduan)
Comment on attachment 8565327 [details] [review]
[gaia] cctuan:1133454 > mozilla-b2g:master

Hi Alive,
could you check this patch?
Attachment #8565327 - Flags: review?(alive)
Comment on attachment 8565327 [details] [review]
[gaia] cctuan:1133454 > mozilla-b2g:master

Why is this fixing the problem? Also I am seeing "name" in system app's manifest.. what is the real problem?
Sorry, I should explain more in my patch and correct the title of this bug.

As I know, there's a test script that would click rocket bar in homescreen and check the current app's name. However, the seachWindow object doesn't have name attribute and it might probably break QA's test flow.
Flags: needinfo?(alive)
Summary: [System] having a name attribute on system app? → [System] having a name attribute on search app
Flags: needinfo?(alive)
Attachment #8565327 - Flags: review?(alive) → review+
Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/5943cf88a468a2220df3ba0449c99e8ac154f5c1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
can this be uplift to v2.2?
Comment on attachment 8565327 [details] [review]
[gaia] cctuan:1133454 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): No.
[User impact] if declined:
it would affect rocketbar related tests. However, it may not affect user.
[Testing completed]:
Yes, I've checked name attribute of searchWindow object when it's on the top and it does work.
[Risk to taking this patch] (and alternatives if risky): No.
[String changes made]:
Attachment #8565327 - Flags: approval-gaia-v2.2?
Attachment #8565327 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: