1133468 - Intermittent test_modal_dialogs.py TestGlobalModals.test_onbeforeunload_accept | AssertionError: u'http://127.0.0.1:49228/modal_dialogs.html#' != 'about:blank'

Status: RESOLVED WORKSFORME

(Testing :: Marionette Client and Harness, defect)

Description

[Carsten Book [:Tomcat]]

Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test marionette

https://treeherder.mozilla.org/logviewer.html#?job_id=6631500&repo=mozilla-inbound

10:26:09 ERROR - TEST-UNEXPECTED-FAIL | test_modal_dialogs.py TestGlobalModals.test_onbeforeunload_accept | AssertionError: u'http://127.0.0.1:49228/modal_dialogs.html#' != 'about:blank'

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6631500
repository: mozilla-inbound
start_time: 2015-02-14T10:19:44
who: tomcat[at]mozilla[dot]com
machine: t-snow-r4-0143
buildname: Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test marionette
revision: 509c07949a4c

TEST-UNEXPECTED-FAIL | test_modal_dialogs.py TestGlobalModals.test_onbeforeunload_accept | AssertionError: u'http://127.0.0.1:49228/modal_dialogs.html#' != 'about:blank'
Return code: 10

Comment 2

[Chris Manchester (limited bugmail, email directly)]

I think I see the issue here.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1133468/chmanchester

/r/4023 - Bug 1133468 - Use wait_for_condition rather than immediately checking for a url update in marionette's modal handling code.;r=automatedtester

Pull down this commit:

hg pull review -r 430f030096bfde4b0c9a6dfc86e13ba2ada6ac97

Comment 4

[David Burns :automatedtester]

Comment on attachment 8566242 [details]
MozReview Request: bz://1133468/chmanchester

https://reviewboard.mozilla.org/r/4021/#review3203

Ship It!

Comment 5

[Chris Manchester (limited bugmail, email directly)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07a480f4761e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/07a480f4761e

Comment 7

[David Burns :automatedtester]

This has not been hit for over 2 months. Closing these bugs

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1133468 - Use wait_for_condition rather than immediately checking for a url update in marionette's modal handling code.;r=automatedtester

Comment 10

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.

Comment 11

[BMO Automation]

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.