1133479 - Fix media/gmp-clearkey build on mingw.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jacek Caban]

Attachment: fix

I get following error:

AnnexB.cpp:41:30: error: invalid initialization of non-const reference of type ‘__gnu_cxx::__normal_iterator<const unsigned char*, std::vector<unsigned char> >&’ from an rvalue of type ‘__gnu_cxx::__normal_iterator<const unsigned char*, std::vector<unsigned char> >’

Also, GCC doesn't support #pragma comment(lib,...), so we need an explicit mfuuid import in moz.build.

I also fixed a few warnings about unused variables.

Comment 1

[Jacek Caban]

Thanks for review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/649d598d8ee1

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/649d598d8ee1

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d8e655d11fc5

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572377 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572377 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.