Closed
Bug 1133479
Opened 8 years ago
Closed 8 years ago
Fix media/gmp-clearkey build on mingw.
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(2 files)
3.85 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
3.85 KB,
patch
|
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
I get following error: AnnexB.cpp:41:30: error: invalid initialization of non-const reference of type ‘__gnu_cxx::__normal_iterator<const unsigned char*, std::vector<unsigned char> >&’ from an rvalue of type ‘__gnu_cxx::__normal_iterator<const unsigned char*, std::vector<unsigned char> >’ Also, GCC doesn't support #pragma comment(lib,...), so we need an explicit mfuuid import in moz.build. I also fixed a few warnings about unused variables.
Attachment #8564976 -
Flags: review?(cpearce)
Updated•8 years ago
|
Attachment #8564976 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 1•8 years ago
|
||
Thanks for review. https://hg.mozilla.org/integration/mozilla-inbound/rev/649d598d8ee1
Comment 2•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/649d598d8ee1
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•8 years ago
|
Blocks: eme-platform-uplift
Comment 3•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/d8e655d11fc5
status-firefox37:
--- → fixed
Comment 4•8 years ago
|
||
Patch for beta branch as part of EME platform uplift.
Comment 5•8 years ago
|
||
Comment on attachment 8572377 [details] [diff] [review] Beta patch Requesting retroactive approval for Beta landing as part of EME platform uplift.
Attachment #8572377 -
Flags: approval-mozilla-beta?
Comment 6•8 years ago
|
||
Comment on attachment 8572377 [details] [diff] [review] Beta patch Approved for Beta as part of EME platform uplift.
Attachment #8572377 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•