1133540 - Fix assertion failure in versionchange when exceptions are thrown

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

I found this accidentally, but basically my assertions fail in this strange use case.

We need two databases. The first needs to be a low version number that gets closed when a second higher version number database is created. Then the upgradeneeded event for the second database throws an exception and triggers an abort/close.

Opt builds should be fine.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Add Test Coverage for the Assertion. r=khuey

After further review, I found that the assertion added in patch v1 has been covered in patch part 4 of Bug 1149815 [1].

Hence, I only picked up the test case from v1 with a new helper function called |expectUncaughtException| in helpers.js to ensure that the test case can be verified in both window/worker in mochitest.

Set r? again because |expectUncaughtException| has to be introduced in patch v2.

Treeherder results in M3(Linux Debug) and M2(Linux Opt) are green. [2]

[1] https://hg.mozilla.org/mozilla-central/diff/a9e5be3e74b2/dom/indexedDB/ActorsParent.cpp
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b326e70ca41&selectedJob=20662535

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

treeherder result in comment 1 looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b326e70ca41

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd0ff7040a37

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd0ff7040a37