1133545 - Create a shortcut to focus the Filter field

Status: VERIFIED FIXED

(Tree Management :: Treeherder, enhancement, P3)

Description

[Jonathan French (:jfrench)]

Split off from bug 1131830, it might be handy to have a shortcut (eg. 'f') which focuses the Filter search field, eliminating the need for manual mouse-click for its input.

This could also serve as an additional keyboard-based method to clear the Filter, per the UI feature request in bug 1083725. eg. 'r', then in the OS just issue the keyboard equivalents to select all and delete.

As that workflow presently works with classification comments.

Comment 1

[Ed Morley [:emorley]]

I think this would be great :-)

Comment 2

[Jonathan French (:jfrench)]

Once PR368 for mousetrap shortcuts is merged and fine, I'll have at this one.

Comment 3

[Jonathan French (:jfrench)]

I've got this sorted, PR coming up shortly.

Comment 4

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#393

Please see above PR for status and review.

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8570747 [details] [review]
treeherder-ui-PR#393

Just clearing the review while you checkout my proposed change.  Thanks!!

Comment 6

[Jonathan French (:jfrench)]

Comment on attachment 8570747 [details] [review]
treeherder-ui-PR#393

That's a sweet approach. I've pushed the angular trigger change to my branch for review, but I'd like to squash before we merge.

Everything seems to be working correctly on both Firefox and Chrome with this approach, no perceptible performance difference.

Comment 7

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/2d2a386047b0a2c5cdcfbc4e09418a4803892ecd
Bug 1133545 - Create a shortcut to focus the Filter field

https://github.com/mozilla/treeherder-ui/commit/f46ffa8fa5a7f692734999fd75f23df3a49d6eea
Bug 1133545 - Create a shortcut to focus the Filter field - angular trigger

https://github.com/mozilla/treeherder-ui/commit/9937d0de1b6d5ffc1a992c3ac37c8636c00caa62
Merge pull request #393 from tojonmz/filter-shortcut

Bug 1133545 - Create a shortcut to focus the Filter field

Comment 8

[Jonathan French (:jfrench)]

Marking fixed per above merge. I will verify on the next push to stage/prod.

We have this also on dev now, so marking Ryan for sheriff feedback and approval.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Substantially better UX, thanks!

Comment 10

[Jonathan French (:jfrench)]

Cool. Yah the flow for filtering back and forth at will without a mouse, is awesome.

Verified fixed on stage.

Comment 11

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8c9c550b2d18552964ea5efe72f495229bf5cef1
Bug 1133545 - Create a shortcut to focus the Filter field

https://github.com/mozilla/treeherder/commit/dcc5b26fcd182b7356e372f035c1404316be3ed3
Bug 1133545 - Create a shortcut to focus the Filter field - angular trigger

https://github.com/mozilla/treeherder/commit/b3dda608d5c48ba5b07923e48ff944f48f64e598
Merge pull request #393 from tojonmz/filter-shortcut

Bug 1133545 - Create a shortcut to focus the Filter field