Chatzilla's <toolbar> needs some "class"

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
minor
RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: Robert John Churchill, Assigned: Robert Ginda)

Tracking

Trunk
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

17 years ago
Rob, as you didn't merge your chatzilla branch onto the trunk upon landing, this 
change was lost. Please put  class="chromeclass-toolbar"  on Chatzilla's <
toolbar> so that on Mac OS X the window's toolbar widget can hide/show it.  
Here's a trivial diff:


Index: mozilla/extensions/irc/xul/content/chatzilla.xul
===================================================================
RCS file: /cvsroot/mozilla/extensions/irc/xul/content/chatzilla.xul,v
retrieving revision 1.34
diff -w -u -2 -r1.34 chatzilla.xul
--- mozilla/extensions/irc/xul/content/chatzilla.xul	4 Dec 2001 00:20:35 -0000	
1.34
+++ mozilla/extensions/irc/xul/content/chatzilla.xul	4 Dec 2001 00:40:54 -0000
@@ -117,5 +117,5 @@
         <vbox flex="1">
           <toolbox id="header-bar-tbox" crop="right" persist="collapsed">
-            <toolbar id="header-bar-tbar"
+            <toolbar class="chromeclass-toolbar" id="header-bar-tbar"
               grippytooltip="aTooltip"
               grippytooltiptext="&header.tooltip;" crop="right">
(Assignee)

Comment 1

17 years ago
I did in fact merged with the trunk before landing.  Your change got lost in the
sea of conflicts in chatzilla.xul, try taking a look at the diff.

Maybe the next time you change some code in one of my modules you could give me
a heads up before you do it.  Then I could point you to a potential branch or
make the change myself.  Maybe then I wouldn't have to find out about it at pool
night, where I'm sure to forget it.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

17 years ago
> Maybe the next time you change some code in one of my modules you could give me
a heads up before you do it.


Actually, I did tell you about it (at pool night) *before* I checked in, Rob.  As 
for your memory, I'll bring in some Centrum Extra Strengh vitamins for you.

Thanks for checking in the patch.  :)
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.