Closed Bug 1133600 Opened 5 years ago Closed 5 years ago

Drop monitor before shutting down AudioStream

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

Details

Attachments

(1 file)

Spun off from bug 1108793.

AudioSink::Cleanup asserts that the monitor is held while doing a bunch of shutdown stuff, including shutting down the AudioStream.  If the code is rearranged, it shouldn't be necessary to hold the monitor for the AudioStream shutdown.
Attached patch patch v0Splinter Review
Attachment #8565198 - Flags: review?(cpearce)
Comment on attachment 8565198 [details] [diff] [review]
patch v0

Review of attachment 8565198 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8565198 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/ab7017697a2b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.