Closed Bug 1133617 Opened 5 years ago Closed 5 years ago

[Reftest Analyzer] Skip filling log into the textarea for log loaded from url or param

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

Currently, for log loaded from url (with param 'logurl') or param (with param 'log'), the analyzer first fills the textarea#logentry with the log content, then calls log_pasted to process. This step is unnecessary, and may cause performance problem if there are addons which tries to interact with the textarea.
Attached patch patchSplinter Review
Attachment #8565223 - Flags: review?(dbaron)
Comment on attachment 8565223 [details] [diff] [review]
patch

Don't you need to move show_phase("loading") into both branches of the if/else so that you don't hide the input and textarea for direct use of reftest-analyzer?

(I think it's fine to have it before creating the XMLHttpRequest in the logurl case, though.)

r=dbaron with that
Attachment #8565223 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/77accbb4e3f9
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
It is a tool for test, but not really something in the testsuite I think.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.