Closed Bug 1133618 Opened 5 years ago Closed 5 years ago

Move SHA1 function from pkixtestnss to pkixtestutil

Categories

(Core :: Security: PSM, defect, minor)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: briansmith, Assigned: briansmith)

Details

Attachments

(1 file, 1 obsolete file)

move-SHA1.patch
3.60 KB, patch
briansmith
: review+
Details | Diff | Splinter Review
Attached patch move-SHA1.patch (obsolete) — — Splinter Review 
TestDigestBuf was added after the SHA1 function was added. Now the SHA1 function can be implemented in terms of TestDigestBuf instead of using NSS-specific code, and it's better to do it that way in order to minimize the amount of NSS-specific code.
Attachment #8565229 - Flags: review?(mmc)
Attachment #8565229 - Flags: review?(mmc) → review+
Attached patch move-SHA1.patch — — Splinter Review 
Carrying over r+. Just updating commit message.
Attachment #8565229 - Attachment is obsolete: true
Attachment #8567382 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/e4883b7af6ba
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.