1133625 - Prepare Append Algorithm should return QuotaExceededError when exceeding buffer size

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

As per spec:
http://w3c.github.io/media-source/#sourcebuffer-prepare-append
"If the buffer full flag equals true, then throw a QuotaExceededError exception and abort these step."

If after evicting data the size of our TrackBuffer still exceeds the threshold size, we should return a QuotaExceededError error.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Fix mochitest so it doesn't append data forever

This mochitest triggered a quota exceeded error. Turned out, it was appending 190306 bytes in a loop, which on my machine would reach 75MB before loadedmetadata got fired.

Comment 2

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f795ff4474ab

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Return an error when attempting to append too much data

Implement step 6 of the Prepare Append Algorithm, if our buffer is full, throw a quota exceeded error

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Don't accept buffer exceeding our threshold

Shouldn't allow an append greater than our threshold. However, YouTube attempts to load data in excess of 8MB when close to the end of the
video, and never attempts to re-append should it error. As such,
the sourcebuffer threshold can't be set to lower than 8MB with this change.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/661dcf41cef9
https://hg.mozilla.org/mozilla-central/rev/af39fc4994cc
https://hg.mozilla.org/mozilla-central/rev/74014ad8e1f8

Comment 6

[Ralph Giles (:rillian)]

Pushed to 37 aurora as well with pre-approval from lmandel.

https://hg.mozilla.org/releases/mozilla-aurora/rev/050e1d7b5246
https://hg.mozilla.org/releases/mozilla-aurora/rev/77ec05774a77
https://hg.mozilla.org/releases/mozilla-aurora/rev/419b32569a76

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8565256 [details] [diff] [review]
Return an error when attempting to append too much data

Requestion retroactive 37 uplift approval for all patches on this bug.

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Spec compliance, less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c. Mochitests.
[Risks and why]: MSE-specific, so low.
[String/UUID change made/needed]: None.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8565256 [details] [diff] [review]
Return an error when attempting to append too much data

As stated, this bug was pre-approved to land with a set of changes for MSE. Marking the approval after the fact.