Closed Bug 1133625 Opened 6 years ago Closed 6 years ago

Prepare Append Algorithm should return QuotaExceededError when exceeding buffer size

Categories

(Core :: Audio/Video, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

As per spec:
http://w3c.github.io/media-source/#sourcebuffer-prepare-append
"If the buffer full flag equals true, then throw a QuotaExceededError exception and abort these step."

If after evicting data the size of our TrackBuffer still exceeds the threshold size, we should return a QuotaExceededError error.
This mochitest triggered a quota exceeded error. Turned out, it was appending 190306 bytes in a loop, which on my machine would reach 75MB before loadedmetadata got fired.
Attachment #8565251 - Flags: review?(cajbir.bugzilla)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Implement step 6 of the Prepare Append Algorithm, if our buffer is full, throw a quota exceeded error
Attachment #8565256 - Flags: review?(cajbir.bugzilla)
Priority: -- → P2
Attachment #8565251 - Flags: review?(cajbir.bugzilla) → review+
Attachment #8565256 - Flags: review?(cajbir.bugzilla) → review+
Shouldn't allow an append greater than our threshold. However, YouTube attempts to load data in excess of 8MB when close to the end of the
video, and never attempts to re-append should it error. As such,
the sourcebuffer threshold can't be set to lower than 8MB with this change.
Attachment #8566208 - Flags: review?(cajbir.bugzilla)
Attachment #8566208 - Flags: review?(cajbir.bugzilla) → review+
Comment on attachment 8565256 [details] [diff] [review]
Return an error when attempting to append too much data

Requestion retroactive 37 uplift approval for all patches on this bug.

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Spec compliance, less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c. Mochitests.
[Risks and why]: MSE-specific, so low.
[String/UUID change made/needed]: None.
Attachment #8565256 - Flags: approval-mozilla-aurora?
Comment on attachment 8565256 [details] [diff] [review]
Return an error when attempting to append too much data

As stated, this bug was pre-approved to land with a set of changes for MSE. Marking the approval after the fact.
Attachment #8565256 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8565251 - Flags: approval-mozilla-aurora+
Attachment #8566208 - Flags: approval-mozilla-aurora+
Blocks: 1136138
You need to log in before you can comment on or make changes to this bug.