Closed
Bug 1133649
Opened 9 years ago
Closed 9 years ago
[B2G] 'xpcshell-test' is not a testing option in mach command.
Categories
(Testing :: XPCShell Harness, defect, P1)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: bevis, Assigned: aknow)
Details
Attachments
(1 file)
1.24 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
After typing './mach help' in $B2G_PATH in m-c branch, I can not find "xpcshell-test" as one of the testing options in mach command which was available few weeks ago. Is this a bug or do we have to run xpcshell-test by other commands?
Reporter | ||
Comment 1•9 years ago
|
||
BTW, I am running xpcshell-test in emulator(ics) and got error as followed: $ ./mach xpcshell-test It looks like you are trying to run an unknown mach command: xpcshell-test Did you want to run any of these commands instead: mochitest? Run |mach help| to show a list of commands.
Reporter | ||
Comment 2•9 years ago
|
||
Hi Ted, Are you the right person for help to check this problem?
Severity: normal → critical
Flags: needinfo?(ted)
Priority: -- → P1
Assignee | ||
Comment 3•9 years ago
|
||
In b2g's tools/mach_b2g_bootstrap.py, it set |require_conditions| to true. However, there is no specific |conditions| in |xpcshell-test| so the command is not registered when we run ./mach in b2g. From testing/xpcshell/mach_commands.py, the command |xpcshell-test| should be available in b2g or even android environment. I think we could add a condition that always return True.
Attachment #8572445 -
Flags: review?(gps)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → szchen
Comment 4•9 years ago
|
||
Comment on attachment 8572445 [details] [diff] [review] Add an always true condition for xpcshell-test Review of attachment 8572445 [details] [diff] [review]: ----------------------------------------------------------------- I'm not a super big fan of this pattern. But it's a sufficient workaround.
Attachment #8572445 -
Flags: review?(gps) → review+
Assignee | ||
Comment 5•9 years ago
|
||
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cb665d0abc5
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/bfa1fee54541
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(ted)
https://hg.mozilla.org/mozilla-central/rev/bfa1fee54541
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•