Intermittent css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions | nsRubyTextContainer breaks the assertion in nsTextFrame

RESOLVED FIXED in Firefox 38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

({intermittent-failure})

Trunk
mozilla38
intermittent-failure
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox36 unaffected, firefox37 unaffected, firefox38 fixed, firefox-esr31 unaffected)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

4 years ago
In nsTextFrame::BuildTextRuns, there is an assertion "Breakable non-block line containers not supported". This is assertion could be broken by nsRubyTextContainer, because it is an non-block line container but is breakable.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

4 years ago
Keywords: intermittent-failure
Summary: nsRubyTextContainer breaks the assertion in nsTextFrame → Intermittent css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions | nsRubyTextContainer breaks the assertion in nsTextFrame
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 8

4 years ago
Created attachment 8565659 [details] [diff] [review]
patch
Assignee: nobody → quanxunzhen
Attachment #8565659 - Flags: review?(roc)
(Assignee)

Comment 9

4 years ago
Comment on attachment 8565659 [details] [diff] [review]
patch

This patch makes ruby texts disappear...
Attachment #8565659 - Flags: review?(roc)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 13

4 years ago
Created attachment 8565749 [details] [diff] [review]
patch 1 - Remove useless check
Attachment #8565749 - Flags: review?(roc)
(Assignee)

Comment 14

4 years ago
Created attachment 8565752 [details] [diff] [review]
patch 2 - Scan into ruby text for building text run
Attachment #8565659 - Attachment is obsolete: true
Attachment #8565752 - Flags: review?(roc)
(Assignee)

Comment 15

4 years ago
Created attachment 8565753 [details] [diff] [review]
patch 3 - Make ruby text not continue text run
Attachment #8565753 - Flags: review?(roc)
(Assignee)

Comment 16

4 years ago
Created attachment 8565772 [details] [diff] [review]
patch 3 - Make ruby text not continue text run
Attachment #8565753 - Attachment is obsolete: true
Attachment #8565753 - Flags: review?(roc)
Attachment #8565772 - Flags: review?(roc)
Comment on attachment 8565772 [details] [diff] [review]
patch 3 - Make ruby text not continue text run

Review of attachment 8565772 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsLineLayout.cpp
@@ +224,5 @@
>    }
>  
>    mBStartEdge = aBCoord;
>  
> +  mSuppressLineWrap = mSuppressLineWrap || LineContainerFrame()->IsSVGText();

This doesn't seem to do anything since SVGTextFrame has an anonymous block child where line layout happens. Just remove it (after verifying this).
Attachment #8565772 - Flags: review?(roc) → review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/9b1a31955666
https://hg.mozilla.org/mozilla-central/rev/a9dfc4f7e628
https://hg.mozilla.org/mozilla-central/rev/8988da1e5c0f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox38: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
status-firefox36: --- → unaffected
status-firefox37: --- → unaffected
status-firefox-esr31: --- → unaffected
Comment hidden (Treeherder Robot)
You need to log in before you can comment on or make changes to this bug.