Closed Bug 1133697 Opened 5 years ago Closed 5 years ago

Intermittent css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions | nsRubyTextContainer breaks the assertion in nsTextFrame

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox36 --- unaffected
firefox37 --- unaffected
firefox38 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

(Keywords: intermittent-failure)

Attachments

(3 files, 2 obsolete files)

patch 1 - Remove useless check
3.04 KB, patch
roc
: review+
Details | Diff | Splinter Review
patch 2 - Scan into ruby text for building text run
3.02 KB, patch
roc
: review+
Details | Diff | Splinter Review
patch 3 - Make ruby text not continue text run
6.88 KB, patch
roc
: review+
Details | Diff | Splinter Review 
In nsTextFrame::BuildTextRuns, there is an assertion "Breakable non-block line containers not supported". This is assertion could be broken by nsRubyTextContainer, because it is an non-block line container but is breakable.
Keywords: intermittent-failure
Summary: nsRubyTextContainer breaks the assertion in nsTextFrame → Intermittent css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions | nsRubyTextContainer breaks the assertion in nsTextFrame
Attached patch patch (obsolete) — — Splinter Review
Assignee: nobody → quanxunzhen
Attachment #8565659 - Flags: review?(roc)
Comment on attachment 8565659 [details] [diff] [review]
patch

This patch makes ruby texts disappear...
Attachment #8565659 - Flags: review?(roc)
Attachment #8565749 - Flags: review?(roc)
Attachment #8565659 - Attachment is obsolete: true
Attachment #8565752 - Flags: review?(roc)
Attachment #8565753 - Flags: review?(roc)
Attachment #8565753 - Attachment is obsolete: true
Attachment #8565753 - Flags: review?(roc)
Attachment #8565772 - Flags: review?(roc)
Comment on attachment 8565772 [details] [diff] [review]
patch 3 - Make ruby text not continue text run

Review of attachment 8565772 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsLineLayout.cpp
@@ +224,5 @@
>    }
>  
>    mBStartEdge = aBCoord;
>  
> +  mSuppressLineWrap = mSuppressLineWrap || LineContainerFrame()->IsSVGText();

This doesn't seem to do anything since SVGTextFrame has an anonymous block child where line layout happens. Just remove it (after verifying this).
Attachment #8565772 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/9b1a31955666
https://hg.mozilla.org/mozilla-central/rev/a9dfc4f7e628
https://hg.mozilla.org/mozilla-central/rev/8988da1e5c0f
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox38: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.