Closed
Bug 1133697
Opened 6 years ago
Closed 6 years ago
Intermittent css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions | nsRubyTextContainer breaks the assertion in nsTextFrame
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox36 | --- | unaffected |
firefox37 | --- | unaffected |
firefox38 | --- | fixed |
firefox-esr31 | --- | unaffected |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
(Keywords: intermittent-failure)
Attachments
(3 files, 2 obsolete files)
3.04 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
3.02 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
6.88 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
In nsTextFrame::BuildTextRuns, there is an assertion "Breakable non-block line containers not supported". This is assertion could be broken by nsRubyTextContainer, because it is an non-block line container but is breakable.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•6 years ago
|
Keywords: intermittent-failure
Summary: nsRubyTextContainer breaks the assertion in nsTextFrame → Intermittent css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions | nsRubyTextContainer breaks the assertion in nsTextFrame
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 8•6 years ago
|
||
Assignee: nobody → quanxunzhen
Attachment #8565659 -
Flags: review?(roc)
Assignee | ||
Comment 9•6 years ago
|
||
Comment on attachment 8565659 [details] [diff] [review] patch This patch makes ruby texts disappear...
Attachment #8565659 -
Flags: review?(roc)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 13•6 years ago
|
||
Attachment #8565749 -
Flags: review?(roc)
Assignee | ||
Comment 14•6 years ago
|
||
Attachment #8565659 -
Attachment is obsolete: true
Attachment #8565752 -
Flags: review?(roc)
Assignee | ||
Comment 15•6 years ago
|
||
Attachment #8565753 -
Flags: review?(roc)
Attachment #8565749 -
Flags: review?(roc) → review+
Attachment #8565752 -
Flags: review?(roc) → review+
Assignee | ||
Comment 16•6 years ago
|
||
Attachment #8565753 -
Attachment is obsolete: true
Attachment #8565753 -
Flags: review?(roc)
Attachment #8565772 -
Flags: review?(roc)
Comment on attachment 8565772 [details] [diff] [review] patch 3 - Make ruby text not continue text run Review of attachment 8565772 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsLineLayout.cpp @@ +224,5 @@ > } > > mBStartEdge = aBCoord; > > + mSuppressLineWrap = mSuppressLineWrap || LineContainerFrame()->IsSVGText(); This doesn't seem to do anything since SVGTextFrame has an anonymous block child where line layout happens. Just remove it (after verifying this).
Attachment #8565772 -
Flags: review?(roc) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 20•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72db3030d830
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 23•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1a31955666 https://hg.mozilla.org/integration/mozilla-inbound/rev/a9dfc4f7e628 https://hg.mozilla.org/integration/mozilla-inbound/rev/8988da1e5c0f
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 33•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9b1a31955666 https://hg.mozilla.org/mozilla-central/rev/a9dfc4f7e628 https://hg.mozilla.org/mozilla-central/rev/8988da1e5c0f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox38:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•6 years ago
|
status-firefox36:
--- → unaffected
status-firefox37:
--- → unaffected
status-firefox-esr31:
--- → unaffected
Comment hidden (Legacy TBPL/Treeherder Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•