1133697 - Intermittent css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions | nsRubyTextContainer breaks the assertion in nsTextFrame

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

In nsTextFrame::BuildTextRuns, there is an assertion "Breakable non-block line containers not supported". This is assertion could be broken by nsRubyTextContainer, because it is an non-block line container but is breakable.

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6675353
repository: mozilla-inbound
start_time: 2015-02-17T01:49:54
who: tomcat[at]mozilla[dot]com
machine: t-w732-ix-081
buildname: Windows 7 32-bit mozilla-inbound debug test reftest
revision: 491e81cd9cf8

REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions
Return code: 1

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6675245
repository: mozilla-inbound
start_time: 2015-02-17T01:44:55
who: tomcat[at]mozilla[dot]com
machine: t-w864-ix-086
buildname: Windows 8 64-bit mozilla-inbound debug test reftest
revision: 7cf148116396

REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions
Return code: 1

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6678958
repository: mozilla-inbound
start_time: 2015-02-17T04:36:01
who: tomcat[at]mozilla[dot]com
machine: t-w732-ix-006
buildname: Windows 7 32-bit mozilla-inbound debug test reftest
revision: ba6d1381814d

REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions
Return code: 1

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6678561
repository: mozilla-inbound
start_time: 2015-02-17T05:19:55
who: tomcat[at]mozilla[dot]com
machine: talos-mtnlion-r5-059
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test reftest
revision: a9af12923b89

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6681104
repository: mozilla-inbound
start_time: 2015-02-17T06:29:36
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-009
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test reftest
revision: 934ed2f5f21f

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6689601
repository: mozilla-inbound
start_time: 2015-02-17T11:39:22
who: rvandermeulen[at]mozilla[dot]com
machine: t-snow-r4-0114
buildname: Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test reftest
revision: 78282059eb4a

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2010897
repository: fx-team
start_time: 2015-02-17T12:50:25
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-092
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: 95a87349301f

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8565659 [details] [diff] [review]
patch

This patch makes ruby texts disappear...

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2011602
repository: fx-team
start_time: 2015-02-17T14:41:18
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-096
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: 9d7cc5a9570f

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6705787
repository: mozilla-inbound
start_time: 2015-02-17T15:05:03
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-016
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test reftest
revision: 3292bc65a0ae

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2012338
repository: fx-team
start_time: 2015-02-17T15:22:49
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-083
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: bce595d4ed1c

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 13

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch 1 - Remove useless check

Comment 14

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch 2 - Scan into ruby text for building text run

Comment 15

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch 3 - Make ruby text not continue text run

Comment 16

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch 3 - Make ruby text not continue text run

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8565772 [details] [diff] [review]
patch 3 - Make ruby text not continue text run

Review of attachment 8565772 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsLineLayout.cpp
@@ +224,5 @@
>    }
>  
>    mBStartEdge = aBCoord;
>  
> +  mSuppressLineWrap = mSuppressLineWrap || LineContainerFrame()->IsSVGText();

This doesn't seem to do anything since SVGTextFrame has an anonymous block child where line layout happens. Just remove it (after verifying this).

Comment 18

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6710683
repository: mozilla-inbound
start_time: 2015-02-17T17:26:19
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-089
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test reftest
revision: c43187545daa

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 19

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6711265
repository: mozilla-inbound
start_time: 2015-02-17T18:41:56
who: rvandermeulen[at]mozilla[dot]com
machine: t-snow-r4-0025
buildname: Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test reftest
revision: b8dc15f1f923

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/font-face/cross-iframe-1.html | image comparison (==), max difference: 255, number of differing pixels: 222

Comment 20

[Xidorn Quan [:xidorn] UTC+11]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72db3030d830

Comment 21

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2014505
repository: fx-team
start_time: 2015-02-17T19:06:03
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-074
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: 6500f3e51d78

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 22

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1045809
repository: mozilla-central
start_time: 2015-02-17T19:10:42
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-016
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-central debug test reftest
revision: d94b3b272dbb

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 23

[Xidorn Quan [:xidorn] UTC+11]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1a31955666
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9dfc4f7e628
https://hg.mozilla.org/integration/mozilla-inbound/rev/8988da1e5c0f

Comment 24

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1046910
repository: mozilla-central
start_time: 2015-02-17T19:42:41
who: philringnalda[at]gmail[dot]com
machine: talos-mtnlion-r5-022
buildname: Rev5 MacOSX Mountain Lion 10.8 mozilla-central debug test reftest
revision: 93ddd99ffd86

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 25

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2015411
repository: fx-team
start_time: 2015-02-17T20:15:46
who: philringnalda[at]gmail[dot]com
machine: talos-mtnlion-r5-025
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: 9e8cbc322957

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 26

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2021352
repository: fx-team
start_time: 2015-02-18T08:28:27
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-002
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: f113f8bed398

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 27

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2022855
repository: fx-team
start_time: 2015-02-18T09:44:12
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-091
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: 2cf0e5bc1473

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 28

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2025546
repository: fx-team
start_time: 2015-02-18T12:48:52
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-092
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: 679ce5620669

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 29

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2025827
repository: fx-team
start_time: 2015-02-18T12:57:27
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-061
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: f8366cf7e7c8

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 30

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2027469
repository: fx-team
start_time: 2015-02-18T13:47:50
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-043
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: 1fc897448cad

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 31

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2027958
repository: fx-team
start_time: 2015-02-18T14:16:26
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-086
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: c17419e63808

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 32

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=2029950
repository: fx-team
start_time: 2015-02-18T16:17:17
who: rvandermeulen[at]mozilla[dot]com
machine: talos-mtnlion-r5-059
buildname: Rev5 MacOSX Mountain Lion 10.8 fx-team debug test reftest
revision: 58f815545f09

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions

Comment 33

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b1a31955666
https://hg.mozilla.org/mozilla-central/rev/a9dfc4f7e628
https://hg.mozilla.org/mozilla-central/rev/8988da1e5c0f

Comment 34

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try&job_id=5202286
repository: try
start_time: 2015-02-25T09:12:29
who: ddamjanovic[at]mozilla[dot]com
machine: t-snow-r4-0067
buildname: Rev4 MacOSX Snow Leopard 10.6 try debug test reftest
revision: 94e0bfac59e4

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/css-ruby/line-breaking-1.html | assertion count 1 is more than expected 0 assertions