By class misses constant for 'anon attribute'

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: whimboo, Unassigned, Mentored)

Tracking

({pi-marionette-client})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=py], )

Attachments

(2 attachments)

52 bytes, text/x-github-pull-request
automatedtester
: review+
Details | Review
686 bytes, patch
automatedtester
: review+
Details | Diff | Splinter Review
Via https://github.com/mozilla/firefox-ui-tests/pull/82 we have seen that the `anon attribute` specifier for the By module is not available as constant. It would be good to get this added.

self.marionette.find_element('anon attribute', ...)

vs.

self.marionette.find_element(By.ANON_ATTRIBUTE, ...)

Not sure if there are other anon related specifiers. If not could be ANON only?
Mentor: dburns
Whiteboard: [good first bug][lang=py]
Posted file Patch v1
Attachment #8567686 - Flags: review?(dburns)
Thanks for the patch, this is awesome but I failed to put where I needed the main change. 

This PR can stay but we now need the constant added to https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/by.py#25

add the following to the file 

    ANON_ATTRIBUTE = 'anon attribute'

Thanks!
Comment on attachment 8567686 [details] [review]
Patch v1

as was mentioned in the other comment, we need a change to by.py as well before this can land.
Attachment #8567686 - Flags: review?(dburns) → review+
Posted patch 1133718.patchSplinter Review
Patch By.py
Attachment #8567924 - Flags: review?(dburns)
Please, let me know if there's something else to change and fix. :)
Attachment #8567924 - Flags: review?(dburns) → review+
thanks for that! If you are looking for more Good first bugs in this module have a look at https://wiki.mozilla.org/Auto-tools/Projects/Marionette/Auto-tools/Projects/Marionette/Roadmap#Good_First_Bugs

Sheriffs,

Checkin-needed for patch on m-c code, not the github PR
Thanks David, I will see more bugs.
David, I squashed the commits in the PR. Maybe we can merge it now that patch changes were pushed to mozilla-central and mozilla-inbound. What you think?
Flags: needinfo?(dburns)
Looks like travis is having issues at the moment, leaving n-i to come back and look later to see if the job is done
The PR has been merged. Maybe we should mark this as fixed :)
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(dburns)
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.