1133718 - By class misses constant for 'anon attribute'

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Via https://github.com/mozilla/firefox-ui-tests/pull/82 we have seen that the `anon attribute` specifier for the By module is not available as constant. It would be good to get this added.

self.marionette.find_element('anon attribute', ...)

vs.

self.marionette.find_element(By.ANON_ATTRIBUTE, ...)

Not sure if there are other anon related specifiers. If not could be ANON only?

Comment 1

[Giovanny Gongora [:gioyik]]

Attachment: Patch v1

Comment 2

[David Burns :automatedtester]

Thanks for the patch, this is awesome but I failed to put where I needed the main change. 

This PR can stay but we now need the constant added to https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/by.py#25

add the following to the file 

    ANON_ATTRIBUTE = 'anon attribute'

Thanks!

Comment 3

[David Burns :automatedtester]

Comment on attachment 8567686 [details] [review]
Patch v1

as was mentioned in the other comment, we need a change to by.py as well before this can land.

Comment 4

[Giovanny Gongora [:gioyik]]

Attachment: 1133718.patch

Patch By.py

Comment 5

[Giovanny Gongora [:gioyik]]

Please, let me know if there's something else to change and fix. :)

Comment 6

[David Burns :automatedtester]

thanks for that! If you are looking for more Good first bugs in this module have a look at https://wiki.mozilla.org/Auto-tools/Projects/Marionette/Auto-tools/Projects/Marionette/Roadmap#Good_First_Bugs

Sheriffs,

Checkin-needed for patch on m-c code, not the github PR

Comment 7

[Giovanny Gongora [:gioyik]]

Thanks David, I will see more bugs.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff9e7ac1a3d5

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ff9e7ac1a3d5

Comment 10

[Giovanny Gongora [:gioyik]]

David, I squashed the commits in the PR. Maybe we can merge it now that patch changes were pushed to mozilla-central and mozilla-inbound. What you think?

Comment 11

[David Burns :automatedtester]

Looks like travis is having issues at the moment, leaving n-i to come back and look later to see if the job is done

Comment 12

[Giovanny Gongora [:gioyik]]

The PR has been merged. Maybe we should mark this as fixed :)

Comment 13

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Moving bugs for Marionette client due to component changes.