Closed Bug 1133720 Opened 9 years ago Closed 9 years ago

Remove test test-shared-css app from dev_apps folder

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file, 1 obsolete file)

[gaia] KevinGrandon:bug_1133720_migrate_test_shared_css_app > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rickychien
: review+
Details | Review 
      No description provided.
Ricky - could you take a look at this? Thanks!
Flags: needinfo?(ricky060709)
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Wow that solution is perfect!! I like it.

Please use GAIA_APP_CONFIG as my comment on Github and set r? to me once your patch is ready. =)
Flags: needinfo?(ricky060709)
Attachment #8565403 - Attachment is obsolete: true
Comment on attachment 8565882 [details] [review]
[gaia] KevinGrandon:bug_1133720_migrate_test_shared_css_app > mozilla-b2g:master

Hey Ricky - Thanks for the hint. I updated the test to use GAIA_APP_CONFIG and use a stub file for the app list. What do you think?
Attachment #8565882 - Flags: review?(ricky060709)
Comment on attachment 8565882 [details] [review]
[gaia] KevinGrandon:bug_1133720_migrate_test_shared_css_app > mozilla-b2g:master

This seems fine to me! Note that mac's Gip is red on gaia-try although I think it should be unrelated.
Attachment #8565882 - Flags: review?(ricky060709) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: