Remove test test-shared-css app from dev_apps folder

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 8565403 [details] [review]
[gaia] KevinGrandon:bug_1133714_marketplace_test_apps > mozilla-b2g:master
(Assignee)

Comment 2

4 years ago
Ricky - could you take a look at this? Thanks!
Flags: needinfo?(ricky060709)
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Wow that solution is perfect!! I like it.

Please use GAIA_APP_CONFIG as my comment on Github and set r? to me once your patch is ready. =)
Flags: needinfo?(ricky060709)
(Assignee)

Updated

4 years ago
Attachment #8565403 - Attachment is obsolete: true
Created attachment 8565882 [details] [review]
[gaia] KevinGrandon:bug_1133720_migrate_test_shared_css_app > mozilla-b2g:master
(Assignee)

Comment 5

4 years ago
Comment on attachment 8565882 [details] [review]
[gaia] KevinGrandon:bug_1133720_migrate_test_shared_css_app > mozilla-b2g:master

Hey Ricky - Thanks for the hint. I updated the test to use GAIA_APP_CONFIG and use a stub file for the app list. What do you think?
Attachment #8565882 - Flags: review?(ricky060709)
Comment on attachment 8565882 [details] [review]
[gaia] KevinGrandon:bug_1133720_migrate_test_shared_css_app > mozilla-b2g:master

This seems fine to me! Note that mac's Gip is red on gaia-try although I think it should be unrelated.
Attachment #8565882 - Flags: review?(ricky060709) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.