If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Final copy for Tab Queue

VERIFIED FIXED in Firefox 40

Status

()

Firefox for Android
General
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: mhaigh, Assigned: antlam)

Tracking

37 Branch
Firefox 40
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 verified)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

3 years ago
We're currently working with non final copy for the tab queue - this bug is so we have one point of reference for all text associated with this feature.

Assigning to antlam to provide copy
(Assignee)

Comment 1

3 years ago
Thanks for filing this, can you help me double check the copy needed?

 - First time user experience
 - Toast & Super toast action
 - Notification bar

Am I missing anything?
Flags: needinfo?(mhaigh)
(Reporter)

Comment 2

3 years ago
Created attachment 8565596 [details]
Ciurrent settings menu

We also need the Settings menu.  We need a decision if it makes more sense as a checkbox with a title and a subtitle (as displayed in this screenshot), or a selection list with a title and two options, with the selected option becoming the subtitle.  Also the Customize page text will need adjusting on the first settings page (also in the screen shot)
Flags: needinfo?(mhaigh)
(Assignee)

Comment 3

3 years ago
My proposal:

First time user experience
---
 - Header: "Opening multiple links?"
 - Body: "Open links without having to switch to Firefox each time."
 - Tip: "you can change this later under Settings"
 - Dismiss: "Not now"
 - Call-to-action: "Try it!"

Toast/ Super toast
---
 - "Opening in Firefox" | SWITCH

Notification bar
---
 - Title: New links available in Firefox 
 - Subtitle: # tab(s) waiting
(Assignee)

Comment 4

3 years ago
As for Settings, I think what you have now (1 check box) makes sense. What would the "other" option be?

Settings
---
 - Title: "Open multiple links" (we should have these match, so if we change one, we should change this too)
 - Description: "Queue links in Firefox instead of switching applications each time."
Flags: needinfo?(mhaigh)
(Reporter)

Comment 5

3 years ago
(In reply to Anthony Lam (:antlam) from comment #3)
> 
> Toast/ Super toast
> ---
>  - "Opening in Firefox" | SWITCH
> 

If I understand correctly then this is opposite of the current functionality in which the default is "Open later" and the action button is "Open now". Is this an intentional change?
Flags: needinfo?(mhaigh)
(Assignee)

Comment 6

3 years ago
(In reply to Martyn Haigh (:mhaigh) from comment #5)
> (In reply to Anthony Lam (:antlam) from comment #3)
> > 
> > Toast/ Super toast
> > ---
> >  - "Opening in Firefox" | SWITCH
> > 
> 
> If I understand correctly then this is opposite of the current functionality
> in which the default is "Open later" and the action button is "Open now". Is
> this an intentional change?

No, it should be the same. Default is still "open later" on the left (not clickable), but I changed the wording. The right (action button) says "switch" which should just switch you to Firefox and "open now". 

I just thought having multiple "open" in the toast seemed to imply the user had to make a lot of choices where as this more or less conveys they have done something, but now can make a choice if they want to (like when they open a tab in background.
(Assignee)

Comment 7

3 years ago
Talked in Vidyo, some changes:

First time user experience
---
 - Dismiss: "Not now"
 - Call-to-action: "Enable"
(Assignee)

Comment 8

3 years ago
Updates from conversation: 

In the interest of aligning the toast copy with the system notification copy:

Toast/ Super toast
---
 - "Tab queued in Firefox" | [ ] OPEN

Where [ ] is the switch-to-tab icon that switches to this tab in Fennec.
(Assignee)

Comment 9

3 years ago
Updating from my comment 4. I'd like us to update these soon especially cause more eyes are seeing this now.

Settings
---
 - Title: "Open multiple links" (we should have these match, so if we change one, we should change this too)
 - Description: "Queue links for later instead of switching to Firefox each time"
Flags: needinfo?(mhaigh)
(Reporter)

Comment 10

2 years ago
Created attachment 8594804 [details] [diff] [review]
Final copy for tab queue

As the prompt is currently correct, as is the notification text, I've only changed the wording for the settings and the tab queue toast.
Flags: needinfo?(mhaigh)
Attachment #8594804 - Flags: review?(alam)
(Assignee)

Comment 11

2 years ago
Comment on attachment 8594804 [details] [diff] [review]
Final copy for tab queue

+! 

For the disabled pref in Settings, let's have it as "Switch to Firefox and open links right away."
Flags: needinfo?(mhaigh)
Attachment #8594804 - Flags: review?(alam) → review+
(Reporter)

Comment 12

2 years ago
As agreed with antlam - we'll address the way that preferences and changes are displayed to users in another bug as we want to land this stuff soon.  Bug 1156534 is the meta bug for the settings revamp.
Flags: needinfo?(mhaigh)
(Reporter)

Comment 13

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/85ea3a5e3152
https://hg.mozilla.org/integration/fx-team/rev/19519ebc76bc
Martyn - Note for next time: When changing strings, we need to change the entity too. Notice how Richard bumped the entities in android_strings.dtd, which is needed to notify the localizers that the strings need to be updated. Changes in the strings themselves are not enough for our tools.
https://hg.mozilla.org/mozilla-central/rev/85ea3a5e3152
https://hg.mozilla.org/mozilla-central/rev/19519ebc76bc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Tested with 28-04 Nightly build:

First time user experience
 - Header: "Opening multiple links?"
 - Body: "Open them without switching to Firefox each time."
 - Tip: "you can change this later under Settings"
 - Dismiss: "Not now"
 - Call-to-action: "Enable"

Toast notification:
 - "Tab queued in Nightly" | Open now

Notification bar:
 - "Nightly 
    # tab(s) waiting"

Settings
 - Title: "Open multiple links" 
 - Description: "Queue links for later instead of switching to Nightly each time."
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
Hi all,

Anthony asked me to review this copy. Is there somewhere I could see screenshots of how this works? A few of the strings aren't clear to me.

Thanks.
(Reporter)

Comment 19

2 years ago
Tab Queue is currently enabled in nightly, that's probably the best place to check it out.
Flags: needinfo?(matej)
(In reply to Martyn Haigh (:mhaigh) from comment #19)
> Tab Queue is currently enabled in nightly, that's probably the best place to
> check it out.

Is there anyone in the Toronto office who works on this and could show me how it works? I'm not familiar with the feature and I currently don't have an Android device.
Flags: needinfo?(matej)
(In reply to Teodora Vermesan (:TeoVermesan) from comment #17)
> Tested with 28-04 Nightly build:
> 
> First time user experience
>  - Header: "Opening multiple links?"
>  - Body: "Open them without switching to Firefox each time."
>  - Tip: "you can change this later under Settings"
>  - Dismiss: "Not now"
>  - Call-to-action: "Enable"

If I see this in Firefox, will it be clear that it's referring to opening links from other apps? It feels like it should be something like "Opening links from other apps?" — but that's probably too long.

In the copy, are you actually opening the links? Or are you saving them until you open Firefox again?

Maybe it's something like:

Links from other apps
Save them until the next time you open Firefox


> Toast notification:
>  - "Tab queued in Nightly" | Open now

I worry people won't understand the term "queue" in this case. Maybe "saved" instead?

And is it a tab or a link? We should be consistent in how we refer to them.


> Notification bar:
>  - "Nightly 
>     # tab(s) waiting"
> 
> Settings
>  - Title: "Open multiple links" 
>  - Description: "Queue links for later instead of switching to Nightly each
> time."

Similar comments as above. Are the links actually being opened? And will people understand "queue"?

This could be:

Handling multiple links
Save them until the next time you open Nightly

(Maybe the above copy works for both cases)

I hope that helps. Let me know if you need anything else.
(Assignee)

Comment 22

2 years ago
(In reply to Matej Novak [:matej] from comment #21)
> (In reply to Teodora Vermesan (:TeoVermesan) from comment #17)
> > Tested with 28-04 Nightly build:
> > 
> > First time user experience
> >  - Header: "Opening multiple links?"
> >  - Body: "Open them without switching to Firefox each time."
> >  - Tip: "you can change this later under Settings"
> >  - Dismiss: "Not now"
> >  - Call-to-action: "Enable"
> 
> If I see this in Firefox, will it be clear that it's referring to opening
> links from other apps? It feels like it should be something like "Opening
> links from other apps?" — but that's probably too long.

Yep, this modal slides up only because the user has pressed a link from another app and chose to use Firefox to open said link.

> In the copy, are you actually opening the links? Or are you saving them
> until you open Firefox again?
> 
> Maybe it's something like:
> 
> Links from other apps
> Save them until the next time you open Firefox

I guess we aren't "loading" them until the re-open Firefox. So, technically, "saving" works better actually.

> > Toast notification:
> >  - "Tab queued in Nightly" | Open now
> 
> I worry people won't understand the term "queue" in this case. Maybe "saved"
> instead?
> 
> And is it a tab or a link? We should be consistent in how we refer to them.

"Tab saved in Nightly" WFM! 
 
> > Notification bar:
> >  - "Nightly 
> >     # tab(s) waiting"
> > 
> > Settings
> >  - Title: "Open multiple links" 
> >  - Description: "Queue links for later instead of switching to Nightly each
> > time."
> 
> Similar comments as above. Are the links actually being opened? And will
> people understand "queue"?
> 
> This could be:
> 
> Handling multiple links
> Save them until the next time you open Nightly
> 
> (Maybe the above copy works for both cases)
> 
> I hope that helps. Let me know if you need anything else.

Perfect - Thanks Matej!

Martyn, let's update these strings.
Flags: needinfo?(mhaigh)
(Reporter)

Comment 23

2 years ago
Created attachment 8608173 [details] [diff] [review]
Final copy for Tab Queue
Attachment #8594804 - Attachment is obsolete: true
Flags: needinfo?(mhaigh)
Attachment #8608173 - Flags: review?(michael.l.comella)
Comment on attachment 8608173 [details] [diff] [review]
Final copy for Tab Queue

Review of attachment 8608173 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/locales/en-US/android_strings.dtd
@@ +193,3 @@
>  <!ENTITY tab_queue_toast_action "Open now">
> +<!ENTITY tab_queue_prompt_title2 "Links from other apps">
> +<!ENTITY tab_queue_prompt_text3 "Save them until the next time you open &brandShortName;">

I'm not sure I agree with this copy - isn't Firefox opened when I click a link? I think we might need bug 1148431 first before this copy makes sense.

@@ +394,5 @@
>  <!ENTITY pref_scroll_title_bar2 "Full-screen browsing">
>  <!ENTITY pref_scroll_title_bar_summary "Hide the &brandShortName; title bar when scrolling down a page">
>  
> +<!ENTITY pref_tab_queue_title3 "Handling multiple links">
> +<!ENTITY pref_tab_queue_summary3 "Save them until the next time you open &brandShortName;">

This doesn't seem super intuitive - what is "saving" a link? Shouldn't Firefox open when I click on a link? How do I save a link before then?

I wonder if we should have the "Handling multiple links" menu item, which when you click opens a dialog with a tab queue description and text box to enable the feature, plus a "close" or "confirm" button, that way we have more space to describe what tab queue does.

Perhaps we can use the styling and copy (or even full dialog) from bug 1148431.
Attachment #8608173 - Flags: review?(michael.l.comella) → review+
Anthony, any thoughts on comment 24?
Flags: needinfo?(alam)
(Assignee)

Comment 26

2 years ago
(In reply to Michael Comella (:mcomella) from comment #24)
> >  <!ENTITY tab_queue_toast_action "Open now">
> > +<!ENTITY tab_queue_prompt_title2 "Links from other apps">
> > +<!ENTITY tab_queue_prompt_text3 "Save them until the next time you open &brandShortName;">
>
> I'm not sure I agree with this copy - isn't Firefox opened when I click a
> link? I think we might need bug 1148431 first before this copy makes sense.

Even though Fx is opened, once enabled, the user won't see Fx when the click links. And if I'm understanding this correctly, it gives a reasoning behind that.

Though, I do think we could stick to "Opening multiple links?" rather than "Links from other apps" because I just remembered we use "open multiple links" in settings and that seems to have a better connection. It also matches the overall tone of our Settings more.


> > +<!ENTITY pref_tab_queue_title3 "Handling multiple links">
> > +<!ENTITY pref_tab_queue_summary3 "Save them until the next time you open &brandShortName;">
>
> This doesn't seem super intuitive - what is "saving" a link? Shouldn't
> Firefox open when I click on a link? How do I save a link before then?

"Saving" was terminology that we talked about using before but I can't remember why we went with "queuing" instead. Since (if enabled) Fx doesn't really "open" when the user presses a link, this still makes sense. "Saving" is also a far more commonly used and understood word in this context. It also hints at the "we'll hang onto it" idea that we tried to convey in early attempts at this copy.

As above, let's stick to the same title of "Open multiple links" in Settings rather than "Handling multiple links". But the subtitle that Matej suggested does work better since we use "save" now in the prompt.

> I wonder if we should have the "Handling multiple links" menu item, which
> when you click opens a dialog with a tab queue description and text box to
> enable the feature, plus a "close" or "confirm" button, that way we have
> more space to describe what tab queue does.

Hm, I like the idea of a modal "learn more" dialog inside Settings. Maybe I can think about this as a part of the larger picture in the Settings work we're doing. I'd like to group that work together because it's more relate.
Flags: needinfo?(alam) → needinfo?(michael.l.comella)
(Assignee)

Comment 27

2 years ago
NI-ing Matej for changes and reasoning :) ^
Flags: needinfo?(matej)
(In reply to Anthony Lam (:antlam) from comment #27)
> NI-ing Matej for changes and reasoning :) ^

The thing that's confusing about "Opening multiple links?" is that it isn't a single action that someone can do. If they're opening Firefox after clicking a link somewhere else, that's a single link.

Maybe we should use "Handling multiple links" or "Link handling" (or something) across the board?
Flags: needinfo?(matej)
(Assignee)

Comment 29

2 years ago
(In reply to Matej Novak [:matej] from comment #28)
> The thing that's confusing about "Opening multiple links?" is that it isn't
> a single action that someone can do. If they're opening Firefox after
> clicking a link somewhere else, that's a single link.

hmmm actually this "overlay" actually triggers after a couple of links have been opened in Firefox by the user. So the context is, they see this after they've opened the third (?) link. In that sense, it's almost like "hey, we notice that you've opened your third link in Firefox, *prompt* are you planning on opening multiple links?" 

From that point onwards, every time they open a link somewhere else, they only see a subtle toast, and they never switch to Firefox until they press the Super toast's action or launch it themselves. So that could be any number of links, not just a single.
(In reply to Anthony Lam (:antlam) from comment #29)
> (In reply to Matej Novak [:matej] from comment #28)
> > The thing that's confusing about "Opening multiple links?" is that it isn't
> > a single action that someone can do. If they're opening Firefox after
> > clicking a link somewhere else, that's a single link.
> 
> hmmm actually this "overlay" actually triggers after a couple of links have
> been opened in Firefox by the user. So the context is, they see this after
> they've opened the third (?) link. In that sense, it's almost like "hey, we
> notice that you've opened your third link in Firefox, *prompt* are you
> planning on opening multiple links?" 
> 
> From that point onwards, every time they open a link somewhere else, they
> only see a subtle toast, and they never switch to Firefox until they press
> the Super toast's action or launch it themselves. So that could be any
> number of links, not just a single.

But what if they open those link over the span of a couple of days? Is this timed somehow?

I just want to make sure that it's clear to someone who has no knowledge of or context for this feature.
(Assignee)

Comment 31

2 years ago
(In reply to Matej Novak [:matej] from comment #30)
> (In reply to Anthony Lam (:antlam) from comment #29)
> > (In reply to Matej Novak [:matej] from comment #28)
> > > The thing that's confusing about "Opening multiple links?" is that it isn't
> > > a single action that someone can do. If they're opening Firefox after
> > > clicking a link somewhere else, that's a single link.
> > 
> > hmmm actually this "overlay" actually triggers after a couple of links have
> > been opened in Firefox by the user. So the context is, they see this after
> > they've opened the third (?) link. In that sense, it's almost like "hey, we
> > notice that you've opened your third link in Firefox, *prompt* are you
> > planning on opening multiple links?" 
> > 
> > From that point onwards, every time they open a link somewhere else, they
> > only see a subtle toast, and they never switch to Firefox until they press
> > the Super toast's action or launch it themselves. So that could be any
> > number of links, not just a single.
> 
> But what if they open those link over the span of a couple of days? Is this
> timed somehow?
> 
> I just want to make sure that it's clear to someone who has no knowledge of
> or context for this feature.

Nope, not at first. This will be purely based on a set number of times right now.
Cancelling NI - is there something you needed here?
Flags: needinfo?(michael.l.comella)
(Assignee)

Comment 33

2 years ago
so, we might have to change 2 things in your patch after these comments (Seen above)

1) prompt title to : "Opening multiple links?”
2) settings title to: "Open multiple links

Assuming your patch updated with Matej's copy, I think those are the only 2 updates we have to make :)
Flags: needinfo?(mhaigh)
(Reporter)

Comment 34

2 years ago
Created attachment 8611278 [details] [diff] [review]
Final copy for Tab Queue

Updated to reflect conversation.
Attachment #8608173 - Attachment is obsolete: true
Flags: needinfo?(mhaigh)
Attachment #8611278 - Flags: review?(michael.l.comella)
Comment on attachment 8611278 [details] [diff] [review]
Final copy for Tab Queue

Review of attachment 8611278 [details] [diff] [review]:
-----------------------------------------------------------------

Works technically, but String concerns.

::: mobile/android/base/locales/en-US/android_strings.dtd
@@ +401,5 @@
>  <!ENTITY pref_scroll_title_bar2 "Full-screen browsing">
>  <!ENTITY pref_scroll_title_bar_summary "Hide the &brandShortName; title bar when scrolling down a page">
>  
>  <!ENTITY pref_tab_queue_title2 "Open multiple links">
> +<!ENTITY pref_tab_queue_summary3 "Save them until the next time you open &brandShortName;">

I'm not sure the user would understand that clicking links no longer directly opens Firefox so I'd think this wording can be confusing.
Attachment #8611278 - Flags: review?(michael.l.comella) → review+
(Reporter)

Comment 36

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/f8d2b22cf78c
(Reporter)

Comment 37

2 years ago
Eager to get this landed, but have filed bug 1170135 to revisit this at a later stage.
https://hg.mozilla.org/mozilla-central/rev/f8d2b22cf78c
Depends on: 1171789
You need to log in before you can comment on or make changes to this bug.