Closed Bug 1133772 Opened 5 years ago Closed 5 years ago

[Theme Editor] Edit an app group’s colour theme (i.e media, comms, productivity)

Categories

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cserran, Assigned: etienne)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

37 bytes, text/x-github-pull-request
julienw
: review+
Details | Review
No description provided.
Blocks: 1133773
Blocks: 1133775
Blocks: 1133776
No longer blocks: 1133773, 1133775, 1133776
Priority: -- → P1
Whiteboard: [lightsaber]
Component: Gaia::System → Gaia
No longer blocks: spark-hackerplace
Assignee: nobody → etienne
Attached file Gaia PR
Hey Julien, can you give this a sanity check? You're probably the only other gaia dev with real Studio experience :)
Attachment #8571462 - Flags: review?(felash)
Gave some comments on github, but I want to test a little more on the device so I keep the review req.
Comment on attachment 8571462 [details] [review]
Gaia PR

r=me with the change for the background color.
cool !
Attachment #8571462 - Flags: review?(felash) → review+
Thanks!
https://github.com/fxos/studio/commit/1f305c1b3b8d512fddfbf6ed0ae4346f78e18152
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: Gaia → Gaia::Theme Editor
Whiteboard: [lightsaber] → [spark]
You need to log in before you can comment on or make changes to this bug.