Closed
Bug 113380
Opened 23 years ago
Closed 23 years ago
default languages should be 'en-US, en' instead of 'en-US'
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: jdalbec, Assigned: ftang)
References
()
Details
(Keywords: intl)
Attachments
(1 file)
1004 bytes,
patch
|
tetsuroy
:
review+
alecf
:
superreview+
shaver
:
approval+
|
Details | Diff | Splinter Review |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:0.9.6) Gecko/20011120 BuildID: 2001112012 For correct content negotiation, the language defaults should be 'en-US' followed by 'en' rather than 'en-US' alone. Web servers that do content negotiation are under no obligation to return an 'en' page if no 'en-US' page is available. They may fall back to Indonesian instead (see above URL). Reproducible: Always Steps to Reproduce: 1. Using the default language settings, go to the above web page. 2. Now add 'en' to the language settings and try again. Actual Results: In (1) the page appears in Indonesian. Expected Results: In (2) the page appears in English. Debian 2.2r4, kernel 2.4.12, KDE 2.1.2, AMD K6/MMX
Comment 1•23 years ago
|
||
i18n?
Assignee: sgehani → ftang
Component: Preferences → Internationalization
QA Contact: sairuh → teruko
Updated•23 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
No, the MacOS build does the same thing. I don't use Mozilla on Windows.
*** Bug 123351 has been marked as a duplicate of this bug. ***
I've marked bug 123351 as a duplicate of this; as I noted in that bug, is it possible to have mozilla have a language family default? For example, I have settings of: English/United Kingdom [en-gb] English/United States [en-us] Italian [it] French [fr] Shouldn't mozilla interpret this as: English/United Kingdom [en-gb] English/United States [en-us] English [en] Italian [it] French [fr] I assumed that if 'en-gb' wasn't found, mozilla would fall back on 'en'. I'm sure this is possible, though I'm not so sure if this is feasible. Also, this seems to apply to all OS (I see this on Win NT and XP). I do not have sufficient Bugzilla permissions to change the setting above though...
What you assume is not how content negotiation works. http://www.debian.org/intro/cn#howtoset
Assignee | ||
Comment 8•23 years ago
|
||
good point, let's change it.
Assignee: yokoyama → ftang
Status: ASSIGNED → NEW
Assignee | ||
Comment 9•23 years ago
|
||
Assignee | ||
Comment 10•23 years ago
|
||
I don't think client need to do that. But it won't hurt to change the default setting to en-US, en
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Comment 11•23 years ago
|
||
Comment on attachment 69576 [details] [diff] [review] patch /r=yokoyama
Attachment #69576 -
Flags: review+
Assignee | ||
Updated•23 years ago
|
OS: Linux → All
Hardware: PC → All
Comment 12•23 years ago
|
||
It might be better to have just [en] as the default for Mozilla if you go by the concept of "English is just one of the languages". Each localizers then can add their variety of English at the top to make it, [en-US] > [en] for the US version.
Assignee | ||
Comment 13•23 years ago
|
||
momoi, the current proposal is to change the default of accept_language of english localization from "en-US" to "en-US, en"
Assignee | ||
Comment 14•23 years ago
|
||
I want to make sure both tao and rchen agree with this change.
Comment 15•23 years ago
|
||
> momoi, the current proposal is to change the default of
> accept_language of english localization from "en-US" to "en-US, en"
I know that and that is why I made my comments. I really think
this is an issue of what the default localization is for. Is it for
the US, or are we considering the main release to be for English users
around the world? Because we have to produce the main release in some
language, it would be best that that language is English. That does not
mean it has to be for en-US. [en] has more universality.
At least for Mozilla's main build, that might be the correct
answer. For Netscape's main release, it is clearly "[en-US], [en]".
Comment 16•23 years ago
|
||
I am in favor of "en-US, en" assuming the implication is "en-US" > "en". Rationale: whether we like it or not, en-US is the default UI language and regional setting Mozilla and Netscape clients ship with. Why make it "en" and force people to produce one more "localized" build?
Comment 17•23 years ago
|
||
> Rationale: whether we like it or not, en-US is the default UI
> language and regional setting Mozilla and Netscape clients ship with.
> Why make it "en" and force people to produce one more "localized" build?
You should separate UI language issues from Accept-language issues.
Accept-language is about what lanaguge/regional variety of language the
user prefers to receive the content in. I can be using a US UI build but might
prefer Japanese content. The regional settings are much more relevant to
Accept-Language settings than the UI language.
I looked at Mozilla's default Bookmarks and Sidebar tabs and I don't
see that the URLs there are US-centric. They are more of Mozilla
related links.
This is a pretty superficial look at the URLs in Mozilla and so
perhaps there are other issues I am not aware of. Again, I am not
making this point about Netscape's commercial build, which is
clearly [en-US] first.
Comment 18•23 years ago
|
||
But, do we want to duplicate the pref and overwrite it in the commercial build? Besides, correct me if I am wrong, the urls in Mozilla do point to US websites which produce content in US English.
Comment 19•23 years ago
|
||
> Besides, correct me if I am wrong, the urls in Mozilla do point
> to US websites which produce content in US English.
Tao, the more I think about this issue, the more I feel we should
leave this alone for now. Thanks for the discussion and I will stop
here.
Assignee | ||
Comment 20•23 years ago
|
||
the qestion is in the mozilla "en-US" build, what should be the default value for accept_language. Currently it is "en-US", and we propose to change it to "en-US, en". The change WON'T change the number of localized build, it will only change the setting IN a particular localized build. The reason is sending "en-US" in the accept_language won't match any "en" content on random websites. Therefore if the websites do NOT have content for "en-US" but have content for "en" or "en-GB" it won't return them . However, if we change the default setting to "en-US, en", then it WILL match to either "en-US", "en" or "en-GB"
Assignee | ||
Comment 21•23 years ago
|
||
it looks, like every one agree with changing from "en-US" to "en-US, en" ask for sr=
Updated•23 years ago
|
Attachment #69576 -
Flags: superreview+
Comment 22•23 years ago
|
||
Comment on attachment 69576 [details] [diff] [review] patch sr=alecf
Assignee | ||
Comment 23•23 years ago
|
||
nsbeta1 this will make mozilla work better with server which support accept_language.
Keywords: nsbeta1
Comment on attachment 69576 [details] [diff] [review] patch a=shaver for 0.9.9
Attachment #69576 -
Flags: approval+
Assignee | ||
Comment 25•23 years ago
|
||
fixed and check in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 26•23 years ago
|
||
I tested this in 2002-02-26-03 trunk build. The default language has not changed to 'en-US, en'. It is still 'en-US'. I reopen this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 27•23 years ago
|
||
probably we have not change the ns build.
Assignee | ||
Updated•23 years ago
|
Status: REOPENED → ASSIGNED
Target Milestone: mozilla0.9.9 → mozilla1.0
Comment 28•23 years ago
|
||
build 2002022603 w2k I can't delete the language "English/United States [en-us]" in the preferences dialog. 1. Open the preferences dialog and switch to "Languages" 2. Delete "English/United States [en-us]" 3. Click to "OK". 4. Reopen the preferences dialog. "English/United States [en-us]" is still there. Is this a new bug or is this behavior due to attachment 69576 [details] [diff] [review]?
Comment 29•23 years ago
|
||
RE: Comment #28 See bug 120469 "Unable to remove navigator languages"
Assignee | ||
Comment 30•23 years ago
|
||
ok. I check in the /ns changes close it again.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 31•22 years ago
|
||
Verified as fixed in 04-02 trunk build (all platform).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•