[Private Browser] Cards view overlay for private windows

VERIFIED FIXED in 2.2 S6 (20feb)

Status

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mikehenrty, Assigned: sfoster)

Tracking

unspecified
2.2 S6 (20feb)
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

Details

(Whiteboard: [systemsfe])

Attachments

(3 attachments)

According to the private browser spec (sections 6.1 and 7.1), we need to update the cards view (and show windows in browser) to have a special semi-transparent overlay and icon.

spec:
https://mozilla.app.box.com/s/fanxlaw7ilhm0walsod6hy4ps47v9eh3

assets:
https://mozilla.app.box.com/s/t615fkirlxarti8b0pvv7xn48mm8w90z

icons landed in gaia:
https://github.com/mozilla-b2g/gaia/blob/f1cccc2cdb0c56d8e5cea6300e9ce0b33f0f99fb/apps/system/style/icons/pb_icon.png
Assignee

Updated

4 years ago
Assignee: nobody → sfoster
feature-b2g: --- → 2.2+
Assignee

Comment 1

4 years ago
The card view look/feel is updated in bug 1125095, we need those changes for the private window tab view / task manager specs to make sense.
Depends on: 1125095
Assignee

Comment 2

4 years ago
Eric: the specs seem to disagree with the changes we made to the task manager button bar colors in bug 1125095. The private browsing specs show a mid-grey being used for that button bar for non-private windows and the darker #5f5f5f for private windows, but we use #5f5f5f for non-private windows already (see https://bug1125095.bugzilla.mozilla.org/attachment.cgi?id=8562934)
Flags: needinfo?(epang)
(In reply to Sam Foster [:sfoster] from comment #2)
> Eric: the specs seem to disagree with the changes we made to the task
> manager button bar colors in bug 1125095. The private browsing specs show a
> mid-grey being used for that button bar for non-private windows and the
> darker #5f5f5f for private windows, but we use #5f5f5f for non-private
> windows already (see
> https://bug1125095.bugzilla.mozilla.org/attachment.cgi?id=8562934)

Hey Sam, thanks for catching this.  For now let's see how it looks if they are the same in the Task Manager.  I'm hoping the overlay and icon will be enough to reinforce that it's a private window.  I think it's more important that it's really visible in the tab view.
Flags: needinfo?(epang)
Assignee

Comment 5

4 years ago
Comment on attachment 8566192 [details] [review]
[gaia] sfoster:private-browser-task-manager-overlay-bug-1133826 > mozilla-b2g:master

Here's where I've got to with this so far, but there are issues: 

Ideally, we want the card view to simply show the app window in its current state, i.e. we would see the identification overlay which already has the private browsing background and icon, plus title. That is (mostly) true for all but the active app - which we use a screenshot for. So this patch adds a new overflow (:after content) for that case. And it kinda works, but: 

* Hard to tell, but seems like this exacerbates the current jank with scrolling the card strip
* The card for the active app is currently missing the title in the overlay. I could add that - essentially duplicating the identification overlay structure. But that seems redundant and wrong?
* Transitions are odd. When you show the task manager, the overlay on the active app just snaps in. And right now when you select a card, it zooms in without the overlay, then you see it briefly, then it goes away. Presumably I just messed up with the changes to windows.css and can fix. Ideally we want basically the same behavior(as code as far as possible) as the edge gesture - you see the overlay as it transitions in, then it fades out. I'm not sure that's going to be practical with the current approach.
Attachment #8566192 - Flags: feedback?(etienne)
Target Milestone: --- → 2.2 S6 (20feb)
Blocks: 1098450
No longer blocks: 1131238
Assignee

Comment 6

4 years ago
Comment on attachment 8566192 [details] [review]
[gaia] sfoster:private-browser-task-manager-overlay-bug-1133826 > mozilla-b2g:master

PR updated, so we use the :after overlay for both active/inactive apps. Also tweaked the icon size to better match the spec. Hard to assess transitions right now as we're seeing graphics jank across all of gaia, but it doesn't seem be any worse
Attachment #8566192 - Flags: review?(etienne)
Assignee

Comment 7

4 years ago
Tab view and task manager with private & non-private browser windows
Attachment #8566703 - Flags: ui-review?(epang)
Comment on attachment 8566703 [details]
private-browsing-card-view.png

Hey Sam,  this looks really good.  Just noticed one thing that wasn't in my spec that would really help the transition.  When accessing the task manager/tab view is it possible to fade in the overlay?  At the moment it instantly switches on which looks a little janky.  Ping me to let me know if it's possible.  Thanks!
Comment on attachment 8566192 [details] [review]
[gaia] sfoster:private-browser-task-manager-overlay-bug-1133826 > mozilla-b2g:master

Sweet and simple.
r=me with the transition either removed or actually transitioning ;)
Attachment #8566192 - Flags: review?(etienne)
Attachment #8566192 - Flags: review+
Attachment #8566192 - Flags: feedback?(etienne)
Assignee

Updated

4 years ago
Blocks: 1135123
> Just noticed one thing that wasn't in my
> spec that would really help the transition.  When accessing the task
> manager/tab view is it possible to fade in the overlay?  At the moment it
> instantly switches on which looks a little janky.

It should be possible, but as Etienne says in the PR, it may not perform - we'll have to try it and see. In the meantime I dont think we want to block landing the feature on this, so I've filed bug 1135123 to track this.
Assignee

Updated

4 years ago
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8566703 [details]
private-browsing-card-view.png

Sounds good, thanks Sam!
Attachment #8566703 - Flags: ui-review?(epang) → ui-review+
Seems this hasn't actually been uplifted to 2.2 yet, n?bajaj in case this has slipped the net.
Flags: needinfo?(bbajaj)
Comment on attachment 8566192 [details] [review]
[gaia] sfoster:private-browser-task-manager-overlay-bug-1133826 > mozilla-b2g:master

(In reply to Chris Lord [:cwiiis] from comment #13)
> Seems this hasn't actually been uplifted to 2.2 yet, n?bajaj in case this
> has slipped the net.

Oh, I thought this has made it =( Flipping the needinfo to a 2.2 uplift approval request as this is part of a new feature.


[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Poor private browsing experience.
[Testing completed]: Manual and unit testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, smallish patch and has been baking on master for a while.
[String changes made]: None.
Flags: needinfo?(bbajaj)
Attachment #8566192 - Flags: approval-gaia-v2.2?(bbajaj)
Attachment #8566192 - Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
This bug has been verified as "pass" on latest nightly build of Flame v2.2&master.

STR:
1.Open Browser app
2.Tap 'New private window'.
3.Long tap Home button to go to task manager, or tap '...' menu icon and tap 'Show Windows'.

Actual results: On cards view/'Show Windows' view, the browser private window icon overlays as expected.
See attachment: verified_Flame_v2.2.png
Reproduce rate: 0/10


Device: Flame v2.2 (Verified) 
Build ID               20150715002506
Gaia Revision          84d0c76370dcd3d25813b00de55194730884355b
Gaia Date              2015-07-09 13:09:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a5db6d9850f6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150715.040736
Firmware Date          Wed Jul 15 04:07:49 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Verified)
Build ID               20150715160204
Gaia Revision          b9968cdc4a1dee49848fed6159a59c378cea062d
Gaia Date              2015-07-15 12:13:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/49683d4e9ebd
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150715.192231
Firmware Date          Wed Jul 15 19:22:42 EDT 2015
Bootloader             L1TC000118D0
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.