1133871 - [raptor] Add support for the kk-b2g-emulator to node-mozdevice

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[Robert Wood [:rwood]]

The ro.product.model name is different for b2g-emulator-kk vs b2g-emulator; add the b2g-emulator-kk to the node-mozdevice config.json.

Comment 1

[Robert Wood [:rwood]]

Attachment: https://github.com/eliperelman/node-mozdevice/pull/7

We could slip this in the next mozdevice release along with your changes in bug 1129687

Comment 2

[:Eli Perelman]

Comment on attachment 8566012 [details] [review]
https://github.com/eliperelman/node-mozdevice/pull/7

Looks good, we will put this in the next release like you said.

Comment 3

[Robert Wood [:rwood]]

Merged:

https://github.com/eliperelman/node-mozdevice/commit/06b44deaf8a8614cb168df77e18e5f910a9b1597

Missed the NPM mozdevice release :( so I need to do another publish and corresponding dependency bump in gaia.

Comment 4

[Robert Wood [:rwood]]

Attachment: https://github.com/eliperelman/node-mozdevice/pull/8

Comment 5

[Robert Wood [:rwood]]

Attachment: https://github.com/mozilla-b2g/raptor/pull/16

Comment 6

[Robert Wood [:rwood]]

Merged: https://github.com/eliperelman/node-mozdevice/commit/1fabe32ca5769998c412b2b16e36063fa78dfe4b

Comment 7

[Robert Wood [:rwood]]

Merged: https://github.com/mozilla-b2g/raptor/commit/e1d574a715a6b1ae99cfe8a3cd2b61a97a3b620b

Comment 8

[Robert Wood [:rwood]]

NPM published mozdevice 1.3.1
NPM published gaia-raptor 0.6.1

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia-node-modules] rwood-moz:bug1133871 > mozilla-b2g:master

Comment 10

[Robert Wood [:rwood]]

Attachment: https://github.com/mozilla-b2g/gaia-node-modules/pull/96

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8568548 [details] [review]
https://github.com/mozilla-b2g/gaia-node-modules/pull/96

lgtm!

Comment 12

[Robert Wood [:rwood]]

Thanks Kevin, merged:
https://github.com/mozilla-b2g/gaia-node-modules/commit/895f36648755c5645ea61d6093a57c1e3ca2311c

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] rwood-moz:bug1133871 > mozilla-b2g:master

Comment 14

[Robert Wood [:rwood]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/28427

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8568777 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/28427

Lgtm. TBH - I think if you guys are doing reviews on the raptor page, it should be fine for you to self-review simple manifest bumps for gaia-node-modules and gaia. If you want an extra set of eyes, feel free to ping me, but I'm not sure it's necessary every time :)

Comment 16

[Robert Wood [:rwood]]

Ok sounds good, thanks Kevin!

Comment 17

[Robert Wood [:rwood]]

Sorry to bug you guys, but on the gaia try run, there's a test failure, and I'm not really sure why... any ideas?

17:49:04     INFO -  Error: timeout exceeded!
17:49:04     INFO -      at Object.Client.waitForSync (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:693:16)
17:49:04     INFO -      at Object.Client.waitFor (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:661:60)
17:49:04     INFO -      at Object.MarionetteHelper.waitForElement (/builds/slave/test/gaia/node_modules/marionette-helper/index.js:142:12)
17:49:04     INFO -      at Object.switchProvidersSelect (/builds/slave/test/gaia/apps/search/test/marionette/lib/search.js:128:31)
17:49:04     INFO -      at Context.<anonymous> (/builds/slave/test/gaia/apps/search/test/marionette/change_providers_test.js:59:24)
17:49:04     INFO -      at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:223:21)
17:49:04     INFO -      at Test.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
17:49:04     INFO -      at Runner.runTest (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:373:10)
17:49:04     INFO -      at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:451:12
17:49:04     INFO -      at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:298:14)
17:49:04     INFO -      at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:308:7
17:49:04     INFO -      at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:246:23)
17:49:04     INFO -      at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
17:49:04     INFO -      at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
17:49:04     INFO -      at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:228:7)
17:49:04     INFO -      at Hook.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
17:49:04     INFO -      at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:258:10)
17:49:04     INFO -      at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
17:49:04     INFO -      at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
17:49:04     INFO -      at /builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:199:9
17:49:04     INFO -      at Object.executeHook (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:371:18)
17:49:04     INFO -      at process._tickCallback (node.js:415:13)

Comment 18

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1133871_merge_raptor_update > mozilla-b2g:master

Comment 19

[Kevin Grandon :kgrandon]

This may have been due to a previous error on master. I suggest re-basing and trying again over the top. I've gone ahead and submitted a pull request with your commit to see what gaia-try does in case I beat you to it.

Comment 20

[:Eli Perelman]

I agree with Kevin. It's VERY unlikely any of the Raptor changes could be affecting any of these tests. More likely is there is some other failure. Either re-trigger the test, or rebase your patch against master and push again so there are new tests run.

Comment 21

[Kevin Grandon :kgrandon]

Latest test run looks good. In master: https://github.com/mozilla-b2g/gaia/commit/00272b56366bf2f6c09420efa858b07eac339158