Closed Bug 1133972 Opened 5 years ago Closed 2 years ago

[Customizer] Merge existing add-ons

Categories

(Firefox OS Graveyard :: Gaia::Customizer, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: cserran, Unassigned)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

No description provided.
No longer depends on: 1133970
No longer blocks: spark-p2p-sharing
This is out of the scope of a v1, in my opinion, based on what I know about the add-on generation code, but Justin would know more.
Flags: needinfo?(jdarcangelo)
I believe Justin is working on this since we're a bit ahead of our schedule.
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Flags: needinfo?(jdarcangelo)
Attached file pull-request (master)
Doug: This currently gives you uninstall prompts for each addon you "merge". Other than that, it should be pretty close to complete. I still have a few other little things to add to this, but wanted to get started on the review before it gets too large. Make sure you `bower update` before you test it out.
Attachment #8579559 - Flags: review?(drs)
Comment on attachment 8579559 [details] [review]
pull-request (master)

Death by a thousand cuts. There's nothing seriously wrong, but let's go through another round of review since there are many small issues.

The changes here look fine:
https://github.com/fxos/addon-generator/blob/master/src/addon-merger.js
Attachment #8579559 - Flags: review?(drs) → review-
Whiteboard: [lightsaber] → [ignite]
Bulk update to set the correct component and whiteboard.
Component: Gaia → Gaia::Customizer
Whiteboard: [ignite] → [spark]
Not working on this. Unassigning myself.
Assignee: jdarcangelo → nobody
Status: ASSIGNED → NEW
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.