[META] IOS-139 Support Lightweight Themes

RESOLVED WONTFIX

Status

()

P5
normal
RESOLVED WONTFIX
4 years ago
8 months ago

People

(Reporter: jchaulk, Unassigned, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: drop?)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Ability to apply a lightweight theme. Another card will be created to describe how a user would access themes initially (ie no dependency on AMO-hosted content for initial release)
Mentor: bnicholson, wjohnston
tracking-fennec: --- → ?
tracking-fennec: ? → +
This bug should cover the ability to display the theme image in every area defined in the mockups (behind the tab tray, behind the URL bar curve, etc).
(Reporter)

Updated

4 years ago
Blocks: 1131262
(Reporter)

Updated

4 years ago
Whiteboard: drop?
(Reporter)

Updated

4 years ago
No longer blocks: 1131262
tracking-fennec: + → -
Created attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

This is a start at this. We have to show... a lot of background images here because some of them are in front and some are behind the browser. Alternatively, we could maybe put a single image behind the urlbar/statusbar?

I can try and split it up a bit more, but starting reviews/feedback.
Attachment #8626389 - Flags: review?(sleroux)
Comment on attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

Added a bunch of comments for nits that you can probably ignore but also left some about some architecture things we can change.
Attachment #8626389 - Flags: review?(sleroux) → review-
Comment on attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

Updated. Created a ThemeImageView: UIImageView class that you can basically use wherever you want a theme image. It will automatically update itself when the theme image changes. I left the Weak-list of images in to manage that which means LightweightThemeManager still knows something about views, but it isn't setting constraints on them anymore. I think that's what you wanted (I like this better).
tracking-fennec: - → ---
Attachment #8626389 - Flags: review- → review?
Comment on attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

It's old, but I think this review was supposed to be directed toward sleroux :)
Attachment #8626389 - Flags: review? → review?(sleroux)
Comment on attachment 8626389 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/641

Looks like this patch is pretty bit-rotten. I tried to rebase from RC master but a lot of things went awry. Going to - this and we can come back and pick off the commits and pieces of work for it to work on latest RC.
Attachment #8626389 - Flags: review?(sleroux) → review-

Updated

8 months ago
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.