1134069 - Submit appropriate CSS Ruby tests to W3C test suite

Status: RESOLVED FIXED

(Core :: Layout: Ruby, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

Per bug 1039006 comment 6, we should submit appropriate tests for CSS Ruby to W3C's test suite. Most of them may simply be done via moving them to layout/reftests/w3c-css/submitted/ruby/.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Let's do it step by step.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch 1 - autohiding

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch 2 - inlinize blocks

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8565834 [details] [diff] [review]
patch 2 - inlinize blocks

r=dbaron

(Though one suggestion dholbert had was using "CSS Reference" instead of "CSS Test" in the title of the reference.)

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b1b7aa2bdda
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd506e90e8e7

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Tests migrated to CSSWG repository in https://hg.csswg.org/test/rev/eeefc17e6d6c .

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3b1b7aa2bdda
https://hg.mozilla.org/mozilla-central/rev/dd506e90e8e7

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

Majority of the tests under layout/reftests/css-ruby can probably be moved. Some of the tests were not written in a way which I feel satisified to submit, but I guess that's fine. Having the tests shared is better than nothing... I'll try to find a time to do that next week or so.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 11

[Sean Voisen (:svoisen)]

Xidorn: Do you by chance have time to finish this up? Otherwise I'll find someone to finish the move. Feels like this is still worthwhile to have.

Comment 12

[Xidorn Quan [:xidorn] UTC+11]

It's still worth to have, but I don't think this is super urgent though. I don't think any other implementation has plan to move forward on their ruby implementation this year (Koji said Chrome team is considering this some time next year).

I'll try to find time to go through the tests and submit them within this year.

Comment 13

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1134069 part 3 - Move most appropriate tests into wpt. r?dbaron

Comment 14

[Xidorn Quan [:xidorn] UTC+11]

Clearing ni? and leave-open now, as I think that's all tests we can move for now. Other tests seem to somehow rely on implementation details so we may not want to submit them.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5102c533bc76
part 3 - Move most appropriate tests into wpt. r=dbaron

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20922 for changes under testing/web-platform/tests

Comment 17

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 18

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5102c533bc76

Comment 19

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot