Closed Bug 1134069 Opened 6 years ago Closed 9 months ago

Submit appropriate CSS Ruby tests to W3C test suite

Categories

(Core :: Layout: Ruby, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Per bug 1039006 comment 6, we should submit appropriate tests for CSS Ruby to W3C's test suite. Most of them may simply be done via moving them to layout/reftests/w3c-css/submitted/ruby/.
Let's do it step by step.
Keywords: leave-open
Attachment #8565833 - Flags: review?(dbaron)
Attachment #8565834 - Flags: review?(dbaron)
Attachment #8565833 - Flags: review?(dbaron) → review+
Comment on attachment 8565834 [details] [diff] [review]
patch 2 - inlinize blocks

r=dbaron

(Though one suggestion dholbert had was using "CSS Reference" instead of "CSS Test" in the title of the reference.)
Attachment #8565834 - Flags: review?(dbaron) → review+
Attachment #8565833 - Flags: checkin+
Attachment #8565834 - Flags: checkin+
Component: Layout → Layout: Ruby

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
Flags: needinfo?(svoisen) → needinfo?(xidorn+moz)

Majority of the tests under layout/reftests/css-ruby can probably be moved. Some of the tests were not written in a way which I feel satisified to submit, but I guess that's fine. Having the tests shared is better than nothing... I'll try to find a time to do that next week or so.

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)

Xidorn: Do you by chance have time to finish this up? Otherwise I'll find someone to finish the move. Feels like this is still worthwhile to have.

Flags: needinfo?(svoisen)

It's still worth to have, but I don't think this is super urgent though. I don't think any other implementation has plan to move forward on their ruby implementation this year (Koji said Chrome team is considering this some time next year).

I'll try to find time to go through the tests and submit them within this year.

Clearing ni? and leave-open now, as I think that's all tests we can move for now. Other tests seem to somehow rely on implementation details so we may not want to submit them.

Flags: needinfo?(xidorn+moz)
Keywords: leave-open
Pushed by mozilla@upsuper.org:
https://hg.mozilla.org/integration/autoland/rev/5102c533bc76
part 3 - Move most appropriate tests into wpt. r=dbaron
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20922 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.