Closed
Bug 1134082
Opened 9 years ago
Closed 9 years ago
Error: Shader Editor is still waiting for a WebGL context to be created.
Categories
(DevTools Graveyard :: WebGL Shader Editor, defect)
Tracking
(firefox38 fixed)
RESOLVED
FIXED
Firefox 38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
Details
Attachments
(2 files)
3.80 KB,
text/html
|
Details | |
19.90 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
When visiting the below page, the shader editor waits for a context to be created, and this error occurs. http://www.ambiera.com/coppercube/demo.php?demo=fpsdemo&mode=webgl A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'? See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise Date: Tue Feb 17 2015 19:02:37 GMT-0800 (PST) Full Message: Error: Shader Editor is still waiting for a WebGL context to be created. Full Stack: ShadersEditorsView._getEditor@chrome://browser/content/devtools/shadereditor.js:418:29 ShadersEditorsView._toggleListeners/<@chrome://browser/content/devtools/shadereditor.js:452:14 ShadersEditorsView._toggleListeners@chrome://browser/content/devtools/shadereditor.js:451:24 ShadersEditorsView.setText/<@chrome://browser/content/devtools/shadereditor.js:398:13 TaskImpl_run@resource://gre/modules/Task.jsm:314:40 TaskImpl@resource://gre/modules/Task.jsm:275:3 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14 Task_spawn@resource://gre/modules/Task.jsm:164:12 ShadersEditorsView.setText@chrome://browser/content/devtools/shadereditor.js:397:12 EventsHandler._onTabNavigated/<@chrome://browser/content/devtools/shadereditor.js:143:17 TaskImpl_run@resource://gre/modules/Task.jsm:314:40 TaskImpl@resource://gre/modules/Task.jsm:275:3 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14 Task_spawn@resource://gre/modules/Task.jsm:164:12 EventsHandler._onTabNavigated@chrome://browser/content/devtools/shadereditor.js:126:9 EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/event-emitter.js:137:11 TabTarget__setupRemoteListeners/this._onTabNavigated@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:492:9 eventSource/aProto.emit@resource://gre/modules/devtools/dbg-client.jsm:193:9 DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:992:7 LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:11 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
Assignee | ||
Comment 1•9 years ago
|
||
Seeing this in quite a few demos
Comment 2•9 years ago
|
||
Politely suggest bumping the prio for this being investigated as GDC is coming up. I think this is a larger problem - I can't use the shader editor or canvas debugger with this demo all the way back to Firefox 35 ( current release )
Assignee | ||
Comment 3•9 years ago
|
||
On page load, we lazily load the editors to set their text to empty. If no programs are linked at this point, there's an error that throws since we try to set text on the editors, and the #content is not yet visible. Took a doc from the shader editor tests, and added a 5s delay after pageload before doing shader stuff, to recreate the error. Think I know how to fix this.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•9 years ago
|
||
We attempt to lazily load editors, but this has a byproduct of throwing an error if content is not yet shown, but we still attempt to access the editors on cleanup, clearing out the text, and many other functions inside here. I don't think this is the ideal solution, but it fixes all the tests that were ignoring uncaught promise exceptions, as well as window leaks. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ee041f4be7d
Attachment #8566279 -
Flags: review?(vporof)
Updated•9 years ago
|
Attachment #8566279 -
Flags: review?(vporof) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/923580a290d1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•