1134102 - Move cubeb's stream reconfiguration to render thread

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Attachment: bugX.patch

Introduce a new event, have the notification client hold only the event handle, and make the render loop thread reconfigure the stream when the event is signaled.

I haven't tested this at all yet, but it seems safer than doing a bunch of work on a thread we don't control (where the OnDefaultDeviceChanged callback runs).  I haven't seen any documentation that says the existing design is dangerous, but reducing the number of threads involved in this process should make reasoning about the behaviour somewhat easier.

Applies on top of the changes in bug 1134078.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0ddb81d4ef7

Comment 1

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9278d7bc85e7

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: bug1134102_v1.patch

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8565909 [details] [diff] [review]
bug1134102_v1.patch

Review of attachment 8565909 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is better than my design, you're right.

Comment 4

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3d919e4fdf4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d3d919e4fdf4