Closed Bug 1134107 Opened 10 years ago Closed 10 years ago

search results header on tablet shows two duplicate headers

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kngo, Assigned: kngo)

References

Details

STR: 1. Search on Marketplace 2. Resize to tablet width Expected: 1 header Actual: 2 headers. One says like "XXX has X results", one says "X results" Also, the implementation is a bit messy as it uses some too-general "hide-on-desktop" and "hide-on-mobile" classes. For some reason, "hide-on-mobile" is "display:block" on mobile, then "display: block" on tablet, and "display: none !important;" on desktop. These should be changed so there is a .search-results-header-mobile and .search-results-header-desktop, and it is styled within search.styl. We don't want to share classes between components.
Blocks: 1103195
Assignee: nobody → dspasovski
Priority: -- → P3
Assignee: dspasovski → kngo
https://github.com/mozilla/fireplace/commit/e220cf6056f555b17aafde01a027fda348bbc864
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.