Closed
Bug 1134110
Opened 8 years ago
Closed 8 years ago
other-license/android is unnecessary if Android minimum version is 11 or later.
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(1 file, 1 obsolete file)
1.98 KB,
patch
|
sworkman
:
review+
esawin
:
feedback+
|
Details | Diff | Splinter Review |
Now we has 2 packages for API is 9 or API is 11+. The code of other-license/android (see bug 694325) is for pre-Honeycomb. So it is unnecessary on the package that API is 11+.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8570283 -
Attachment is patch: true
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8570283 -
Attachment is obsolete: true
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8605053 [details] [diff] [review] other-license/android is unnecessary if android version is 11+ Now we has 2 packages for API is 9 or API is 11+. The code of other-license/android (see bug 694325) is for pre-Honeycomb. So it is unnecessary on the package that minimal API version is 11+.
Attachment #8605053 -
Flags: review?(sworkman)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → m_kato
Comment 4•8 years ago
|
||
Comment on attachment 8605053 [details] [diff] [review] other-license/android is unnecessary if android version is 11+ Review of attachment 8605053 [details] [diff] [review]: ----------------------------------------------------------------- Eugen - your recent changes won't be undone with this, right? Just want to verify before r+ing.
Attachment #8605053 -
Flags: feedback?(esawin)
Comment 5•8 years ago
|
||
Comment on attachment 8605053 [details] [diff] [review] other-license/android is unnecessary if android version is 11+ Review of attachment 8605053 [details] [diff] [review]: ----------------------------------------------------------------- Assuming the min SDK version is always correctly set, I think this looks safe.
Attachment #8605053 -
Flags: feedback?(esawin) → feedback+
Comment 6•8 years ago
|
||
Comment on attachment 8605053 [details] [diff] [review] other-license/android is unnecessary if android version is 11+ Review of attachment 8605053 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the feedback Eugen! Looks fine to me too, r=me.
Attachment #8605053 -
Flags: review?(sworkman) → review+
https://hg.mozilla.org/mozilla-central/rev/5017c72ac8aa
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•