1134149 - Throw the correct exceptions when setting withCredentials.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

See the spec: <https://xhr.spec.whatwg.org/#the-withcredentials-attribute>; the code is at <https://mxr.mozilla.org/mozilla-central/source/dom/base/nsXMLHttpRequest.cpp?rev=20729b28eb1e#3368>.

Tests at <http://w3c-test.org/XMLHttpRequest/XMLHttpRequest-withCredentials.html> and <http://w3c-test.org/XMLHttpRequest/XMLHttpRequest-withCredentials.worker>; can also be run with ./mach web-platform-tests --include XMLHttpRequest/XMLHttpRequest-withCredentials.html

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Throw the exception the spec calls for when withCredentials is set on a sent XMLHttpRequest object

You are the lucky reviewer

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8566047 [details] [diff] [review]
Throw the exception the spec calls for when withCredentials is set on a sent XMLHttpRequest object

Review of attachment 8566047 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsXMLHttpRequest.cpp
@@ +108,5 @@
>  #define XML_HTTP_REQUEST_DONE             (1 << 4) // 4 DONE
> +#define XML_HTTP_REQUEST_SENT             (1 << 5) // Internal, corresponds to
> +                                                   // "OPENED and the send()
> +                                                   // flag is set" in spec
> +                                                   // terms..

Two periods?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Removed the extra period: https://hg.mozilla.org/integration/mozilla-inbound/rev/d942232f7ce6

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d942232f7ce6