1134172 - WebIDE does not remember its previous size

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. Open WebIDE from Firefox
2. set it fullscreen
3. close WebIDE
4. Open WebIDE from Firefox

=> it's not full screen and even rather small.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Hmm, interesting.  The size is remembered (at least here) if you don't maximize / fullscreen.  But if you do maximize, that is not retained for next time.

I believe we currently just leave this up to XUL window sizing code.

We are leaning towards pushing WebIDE back into a browser tab (bug 1110216), so at that point we'd give up control of these things.

Comment 2

[Paul Rouget [:paul]]

Attachment: sizemode

Didn't try, but that should do it.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8565988 [details] [diff] [review]
sizemode

Review of attachment 8565988 [details] [diff] [review]:
-----------------------------------------------------------------

Indeed it does!  Want to land it?

Comment 4

[Paul Rouget [:paul]]

ok.

Comment 5

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/7fa78c76bc46

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7fa78c76bc46

Comment 7

[[e-mail]]

 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0) Gecko/20100101 Firefox/40.0 It does remembers the window size now