Closed
Bug 1134216
Opened 9 years ago
Closed 9 years ago
auto-hyphenation fails in content where text-transform has caused a change in string length
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(2 files)
4.50 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
2.79 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
If we end up needing to "merge" characters in a transformed textrun, as when "ß" is uppercased to "SS", any automatic hyphenation that may have been applicable will be lost. Testcase: data:text/html;charset=utf-8,<div lang="de" style="width:0px;-moz-hyphens:auto;text-transform:uppercase">straße should break as "STRA-SSE", but does not hyphenate at all. This happens because nsCaseTransformTextRunFactory::TransformString treats its aCanBreakBeforeArray as being an array of bools, whereas it should be an array of break-flags values as defined for gfxShapedText::CompressedGlyph.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8565990 -
Flags: review?(smontagu)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8565991 -
Flags: review?(smontagu)
Updated•9 years ago
|
Attachment #8565990 -
Flags: review?(smontagu) → review+
Updated•9 years ago
|
Attachment #8565991 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5dcb02f766 https://hg.mozilla.org/integration/mozilla-inbound/rev/11d9b42afb1e
Target Milestone: --- → mozilla38
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8b5dcb02f766 https://hg.mozilla.org/mozilla-central/rev/11d9b42afb1e
You need to log in
before you can comment on or make changes to this bug.
Description
•