1134216 - auto-hyphenation fails in content where text-transform has caused a change in string length

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

If we end up needing to "merge" characters in a transformed textrun, as when "ß" is uppercased to "SS", any automatic hyphenation that may have been applicable will be lost.

Testcase:

  data:text/html;charset=utf-8,<div lang="de"
    style="width:0px;-moz-hyphens:auto;text-transform:uppercase">straße

should break as "STRA-SSE", but does not hyphenate at all.

This happens because nsCaseTransformTextRunFactory::TransformString treats its aCanBreakBeforeArray as being an array of bools, whereas it should be an array of break-flags values as defined for gfxShapedText::CompressedGlyph.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Preserve line-break flags properly when applying text-transform conversions

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Reftest for automatic hyphenation with text-transform

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5dcb02f766
https://hg.mozilla.org/integration/mozilla-inbound/rev/11d9b42afb1e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8b5dcb02f766
https://hg.mozilla.org/mozilla-central/rev/11d9b42afb1e