Closed Bug 1134237 Opened 9 years ago Closed 9 years ago

Port bug 1022581 to TB [Category icons in about:preferences aren't legible when using black-on-white High Contrast mode]

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird38 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 39.0
Tracking Flags:
Tracking Status
thunderbird38 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

Issue.
282.43 KB, image/png
Details
InContentPrefsUseSVG.patch
25.58 KB, patch
jsbruner
: review+
rkent
: approval-comm-aurora+
Details | Diff | Splinter Review 
This makes the InContentPrefs category icons better visible on light HC-themes. And through the usage of SVG automatically the best for HiDPI displays.
Attached patch InContentPrefsUse SVG.patch (obsolete) — — Splinter Review 
This is a 1:1 copy of the FX bug except the special TB icons. I've also added already the account icon for bug 1096006 to this patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8566038 - Flags: review?(josiah)
Comment on attachment 8566038 [details] [diff] [review]
InContentPrefsUse SVG.patch

Review of attachment 8566038 [details] [diff] [review]:
-----------------------------------------------------------------

On OS X at least, the icons in the sidebar are completely missing now. (Except for General, which is using an old preferences icon)
Attachment #8566038 - Flags: review?(josiah) → review-
Attached image Issue. — 

    
    

    
  


  
OS X uses -moz-image-region on normal prefs. Adding -moz-image-region: auto on icon should fix it.

        Attachment #8566038 -
        Attachment is obsolete: true

        Attachment #8570930 -
        Flags: review?(josiah)

    
    

    
  
Comment on attachment 8570930 [details] [diff] [review]
InContentPrefsUseSVG.patch

Review of attachment 8570930 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet, very nice.

        Attachment #8570930 -
        Flags: review?(josiah) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/comm-central/rev/90e685c2b38d -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0

    
    

    
  
Comment on attachment 8570930 [details] [diff] [review]
InContentPrefsUseSVG.patch

[Approval Request Comment]
Regression caused by (bug #): no regression
User impact if declined: No icon for Account Manager when bug 1096006 lands on TB 38.
Testing completed (on c-c, etc.): in c-c
Risk to taking this patch (and alternatives if risky): Low, only icon change from png to svg with needed css changes.

        Attachment #8570930 -
        Flags: approval-comm-aurora?

    
  

        Attachment #8570930 -
        Flags: approval-comm-aurora? → approval-comm-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: