[e10s] "Full Screen" in remote browser causes unsafe CPOW usage warning

RESOLVED FIXED in Firefox 38

Status

()

Firefox
Menus
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Kwan, Assigned: Kwan)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 38
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10sm8+, firefox38 fixed)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1133577 +++

STR:

1) Visit a site with some <video/>s on it in an e10s window
2) Right-click on a <video/>, and choose "Full Screen"

This causes an "unsafe CPOW usage" warning in the Browser Console.

In browser/base/content/nsContextMenu.js:

  fullScreenVideo: function () {
    let video = this.target;
    if (document.mozFullScreenEnabled)
      video.mozRequestFullScreen(); <-- Causes CPOW warning
  },
(Assignee)

Comment 1

3 years ago
Created attachment 8566437 [details] [diff] [review]
Make "Full Screen" context-menu command e10s safe

Applies on top of patch for bug 1134399
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED
Attachment #8566437 - Flags: review?(gavin.sharp)
(Assignee)

Updated

3 years ago
Depends on: 1134399
Attachment #8566437 - Flags: review?(gavin.sharp) → review?(mconley)
tracking-e10s: ? → m8+
Comment on attachment 8566437 [details] [diff] [review]
Make "Full Screen" context-menu command e10s safe

Review of attachment 8566437 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and works as advertised! Thanks Ian!
Attachment #8566437 - Flags: review?(mconley) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/63da271edfa5
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/63da271edfa5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
QA Whiteboard: [good first verify][
QA Whiteboard: [good first verify][ → [good first verify][verify in Nightly only]
You need to log in before you can comment on or make changes to this bug.