Closed Bug 1134409 Opened 5 years ago Closed 5 years ago

[e10s] "Full Screen" in remote browser causes unsafe CPOW usage warning

Categories

(Firefox :: Menus, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 38
Tracking Status
e10s m8+ ---
firefox38 --- fixed

People

(Reporter: Kwan, Assigned: Kwan)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1133577 +++

STR:

1) Visit a site with some <video/>s on it in an e10s window
2) Right-click on a <video/>, and choose "Full Screen"

This causes an "unsafe CPOW usage" warning in the Browser Console.

In browser/base/content/nsContextMenu.js:

  fullScreenVideo: function () {
    let video = this.target;
    if (document.mozFullScreenEnabled)
      video.mozRequestFullScreen(); <-- Causes CPOW warning
  },
Applies on top of patch for bug 1134399
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED
Attachment #8566437 - Flags: review?(gavin.sharp)
Depends on: 1134399
Attachment #8566437 - Flags: review?(gavin.sharp) → review?(mconley)
Comment on attachment 8566437 [details] [diff] [review]
Make "Full Screen" context-menu command e10s safe

Review of attachment 8566437 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and works as advertised! Thanks Ian!
Attachment #8566437 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/63da271edfa5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
QA Whiteboard: [good first verify][
QA Whiteboard: [good first verify][ → [good first verify][verify in Nightly only]
You need to log in before you can comment on or make changes to this bug.